new classes: no longer experimental.

new classes: no longer experimental.

This CL fixes tests that no longer valid and also fixes two issues:
1. 'super()' in non derived constructors.
2. Failure to step into derived constructors.

R=arv@chromium.org, yurys@chromium.org
BUG=v8:3834
LOG=Y

Committed: https://chromium.googlesource.com/v8/v8/+/2707d4c9f4b6e6e600e708b3b08b09d27d594ce7

[Dmitry Lomov (no reviews), 2015-02-12 16:25:25]

PTAL

https://codereview.chromium.org/923443003/diff/1/test/mjsunit/harmony/super.js
File test/mjsunit/harmony/super.js (left):

https://codereview.chromium.org/923443003/diff/1/test/mjsunit/harmony/super.j...
test/mjsunit/harmony/super.js:1864: (function
TestSuperCallSyntacticRestriction() {
These tests are a duplicate of tests in 'classes.js'

[arv (Not doing code reviews), 2015-02-12 16:49:50]

https://codereview.chromium.org/923443003/diff/20001/src/arm64/builtins-arm64.cc
File src/arm64/builtins-arm64.cc (right):

https://codereview.chromium.org/923443003/diff/20001/src/arm64/builtins-arm64...
src/arm64/builtins-arm64.cc:762: 
extra empty line

https://codereview.chromium.org/923443003/diff/20001/src/full-codegen.cc
File src/full-codegen.cc (right):

https://codereview.chromium.org/923443003/diff/20001/src/full-codegen.cc#newc...
src/full-codegen.cc:877: } else {
skip else after return?

https://codereview.chromium.org/923443003/diff/20001/test/mjsunit/harmony/sup...
File test/mjsunit/harmony/super.js (right):

https://codereview.chromium.org/923443003/diff/20001/test/mjsunit/harmony/sup...
test/mjsunit/harmony/super.js:1827: class F extends Object {
This is not the same as `class F {`. It sets up a class side inheritance to
Object, so `F.getOwnPropertyDescriptor === Object.getOwnPropertyDescriptor`.

There is also another very subtle issue with using Object as a constructor.

Given:

var n = new Object(42);
assertTrue(n instanceof Number);

so what happens with

class X extends Object {}
var n2 = new X(42);
assertTrue(n instanceof Number);  ????

See https://bugs.ecmascript.org/show_bug.cgi?id=3550

The bug was resolved in such a way that the assert above would fail.

We should add tests for this edge case.

[Dmitry Lomov (no reviews), 2015-02-12 17:33:55]

Patchset #3 (id:40001) has been deleted

[Dmitry Lomov (no reviews), 2015-02-12 17:34:40]

Comments addressed; PTAL

https://codereview.chromium.org/923443003/diff/20001/src/arm64/builtins-arm64.cc
File src/arm64/builtins-arm64.cc (right):

https://codereview.chromium.org/923443003/diff/20001/src/arm64/builtins-arm64...
src/arm64/builtins-arm64.cc:762: 
On 2015/02/12 16:49:50, arv wrote:
> extra empty line

Done.

https://codereview.chromium.org/923443003/diff/20001/src/full-codegen.cc
File src/full-codegen.cc (right):

https://codereview.chromium.org/923443003/diff/20001/src/full-codegen.cc#newc...
src/full-codegen.cc:877: } else {
On 2015/02/12 16:49:50, arv wrote:
> skip else after return?

Done.

https://codereview.chromium.org/923443003/diff/20001/test/mjsunit/harmony/sup...
File test/mjsunit/harmony/super.js (right):

https://codereview.chromium.org/923443003/diff/20001/test/mjsunit/harmony/sup...
test/mjsunit/harmony/super.js:1827: class F extends Object {
On 2015/02/12 16:49:50, arv wrote:
> This is not the same as `class F {`. It sets up a class side inheritance to
> Object, so `F.getOwnPropertyDescriptor === Object.getOwnPropertyDescriptor`.

Correct, but the distinction is irrelevant for this test - I am just testing
that the change of __proto__ for F causes the rewire.
> 
> There is also another very subtle issue with using Object as a constructor.
> 
> Given:
> 
> var n = new Object(42);
> assertTrue(n instanceof Number);
> 
> so what happens with
> 
> class X extends Object {}
> var n2 = new X(42);
> assertTrue(n instanceof Number);  ????
> 
> See https://bugs.ecmascript.org/show_bug.cgi?id=3550
> 
> The bug was resolved in such a way that the assert above would fail.
> 
> We should add tests for this edge case.

I see; interesting. Right now we will create a Number object; added a test and
filed a bug.

[arv (Not doing code reviews), 2015-02-12 17:38:24]

LGTM

[Dmitry Lomov (no reviews), 2015-02-12 17:40:54]

New patchsets have been uploaded after l-g-t-m from arv@chromium.org

[Dmitry Lomov (no reviews), 2015-02-12 17:41:16]

The CQ bit was checked by dslomov@chromium.org

[commit-bot: I haz the power, 2015-02-12 17:42:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/923443003/80001

[commit-bot: I haz the power, 2015-02-12 17:46:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-12 17:46:24]

Try jobs failed on following builders:
  v8_linux64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/2947)

[Dmitry Lomov (no reviews), 2015-02-12 17:50:20]

The CQ bit was checked by dslomov@chromium.org

[commit-bot: I haz the power, 2015-02-12 17:51:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/923443003/100001

[commit-bot: I haz the power, 2015-02-12 17:55:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-12 17:55:46]

Try jobs failed on following builders:
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/2861)

[Dmitry Lomov (no reviews), 2015-02-12 17:58:59]

The CQ bit was checked by dslomov@chromium.org

[commit-bot: I haz the power, 2015-02-12 18:00:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/923443003/100001

[commit-bot: I haz the power, 2015-02-12 18:03:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-12 18:03:15]

Try jobs failed on following builders:
  v8_linux64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/2953)

[commit-bot: I haz the power, 2015-02-12 18:07:04]

Patchset 5 (id:??) landed as
https://crrev.com/2707d4c9f4b6e6e600e708b3b08b09d27d594ce7
Cr-Commit-Position: refs/heads/master@{#26628}

[Dmitry Lomov (no reviews), 2015-02-12 18:07:07]

Committed patchset #5 (id:100001) manually as
2707d4c9f4b6e6e600e708b3b08b09d27d594ce7 (presubmit successful).