Implement checks for distinctiveIdentifier and persistentState in requestMediaKeySystemAccess().

chromecast/renderer/key_systems_cast.cc

Index: chromecast/renderer/key_systems_cast.cc
diff --git a/chromecast/renderer/key_systems_cast.cc b/chromecast/renderer/key_systems_cast.cc
index 919ebbe802889ccc3e1006fa18f81aeaf12eb94c..099cdb5014ddbc84bb7c289362c361ccc6c6982f 100644
--- a/chromecast/renderer/key_systems_cast.cc
+++ b/chromecast/renderer/key_systems_cast.cc
@@ -20,7 +20,8 @@ namespace shell {
 void AddKeySystemWithCodecs(

[ddorwin, 2015/02/19 01:41:33]

This function is insufficient. I wonder if it is even necessary or we should
just inline it at line 43.
The Cast team will need to provide the new enum values. I assume they are the
same as for Widevine.

[sandersd (OOO until July 31), 2015/02/19 21:08:34]

Done.

     const std::string& key_system_name,
     std::vector< ::media::KeySystemInfo>* concrete_key_systems) {

[ddorwin, 2015/02/19 01:41:33]

can we remove the space before ::?

[sandersd (OOO until July 31), 2015/02/19 21:08:33]

Done.

-  ::media::KeySystemInfo info(key_system_name);
+  ::media::KeySystemInfo info;
+  info.key_system = key_system_name;
   info.supported_codecs = ::media::EME_CODEC_MP4_ALL;

[ddorwin, 2015/02/19 01:41:33]

same as below

[sandersd (OOO until July 31), 2015/02/19 21:08:34]

Done.

   concrete_key_systems->push_back(info);
 }
@@ -28,9 +29,14 @@ void AddKeySystemWithCodecs(
 void AddChromecastKeySystems(
     std::vector< ::media::KeySystemInfo>* key_systems_info) {
 #if defined(WIDEVINE_CDM_AVAILABLE)
-  AddWidevineWithCodecs(cdm::WIDEVINE,
-                        ::media::EME_CODEC_MP4_ALL,
-                        key_systems_info);
+  AddWidevineWithCodecs(
+      cdm::WIDEVINE,
+      ::media::EME_CODEC_MP4_ALL,

[ddorwin, 2015/02/19 01:41:33]

Let's not use *_ALL (I know it was there before but let's fix it).

[sandersd (OOO until July 31), 2015/02/19 21:08:34]

Done.

[sandersd (OOO until July 31), 2015/02/19 21:08:34]

Done.

+      ::media::EME_SESSION_TYPE_NOT_SUPPORTED,  // Persistent license.
+      ::media::EME_SESSION_TYPE_NOT_SUPPORTED,  // Persistent release message.
+      ::media::EME_FEATURE_NOT_SUPPORTED,       // Persistent state.
+      ::media::EME_FEATURE_ALWAYS_AVAILABLE,    // Distinctive identifier.
+      key_systems_info);
 #endif
 
 #if defined(PLAYREADY_CDM_AVAILABLE)