Implement checks for distinctiveIdentifier and persistentState in requestMediaKeySystemAccess().

media/base/key_system_info.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/key_system_info.h"
 
 namespace media {
 
+KeySystemInfo::KeySystemInfo()

[jrummell, 2015/02/14 01:28:35]

Is this required? I don't see any user of it (although maybe hash_map requires
it).

[ddorwin, 2015/02/17 20:56:47]

If so, we should consider eliminating the other one.

[sandersd (OOO until July 31), 2015/02/18 23:41:17]

Yup, it's for hash_map.

[sandersd (OOO until July 31), 2015/02/18 23:41:17]

Done.

+    : supported_init_data_types(EME_INIT_DATA_TYPE_NONE),
+      supported_codecs(EME_CODEC_NONE),
+      persistent_state_requirement(EME_REQUIREMENT_REQUIRED),
+      distinctive_identifier_requirement(EME_REQUIREMENT_REQUIRED),
+      supported_session_types(EME_SESSION_TYPE_NONE),
+      use_aes_decryptor(false) {
+}
+
 KeySystemInfo::KeySystemInfo(const std::string& key_system)
     : key_system(key_system),
       supported_init_data_types(EME_INIT_DATA_TYPE_NONE),
       supported_codecs(EME_CODEC_NONE),
+      persistent_state_requirement(EME_REQUIREMENT_REQUIRED),

[ddorwin, 2015/02/17 20:56:47]

Default to the worst case: For this one, not_allowed (no support). For the
identifier, the worst case is it's required.

[sandersd (OOO until July 31), 2015/02/18 23:41:17]

Changed to an illegal value with DCHECKS. (For future reference though, this is
the correct worst case.)

+      distinctive_identifier_requirement(EME_REQUIREMENT_REQUIRED),
+      supported_session_types(EME_SESSION_TYPE_NONE),
       use_aes_decryptor(false) {
 }
 
-KeySystemInfo::~KeySystemInfo() {
-}
-
 }  // namespace media