Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 923273003: Update diplays even if configuration failed during startup (Closed)

Created:
5 years, 10 months ago by oshima
Modified:
5 years, 10 months ago
Reviewers:
dnicoara
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update diplays even if configuration failed during startup BUG=458416 Committed: https://crrev.com/b2e4077d5c78430e973ffe58edbf925c7161c0c6 Cr-Commit-Position: refs/heads/master@{#317735}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : fix build error in test #

Patch Set 4 : fix test build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -8 lines) Patch
M ash/display/display_change_observer_chromeos.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/display/display_change_observer_chromeos.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M ash/display/display_configurator_animation.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/display/display_configurator_animation.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/display/display_error_observer_chromeos.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/display/display_error_observer_chromeos.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/display/display_error_observer_chromeos_unittest.cc View 1 2 3 3 chunks +13 lines, -4 lines 0 comments Download
M ui/display/chromeos/display_configurator.h View 1 1 chunk +5 lines, -3 lines 0 comments Download
M ui/display/chromeos/display_configurator.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/display/chromeos/display_configurator_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
oshima
5 years, 10 months ago (2015-02-23 17:00:39 UTC) #3
dnicoara
lgtm
5 years, 10 months ago (2015-02-23 17:07:43 UTC) #4
dnicoara
https://codereview.chromium.org/923273003/diff/20001/ui/display/chromeos/display_configurator.h File ui/display/chromeos/display_configurator.h (right): https://codereview.chromium.org/923273003/diff/20001/ui/display/chromeos/display_configurator.h#newcode71 ui/display/chromeos/display_configurator.h:71: // displays that are deteced when faield. s/deteced/detected/ s/faield/failed/
5 years, 10 months ago (2015-02-23 17:08:26 UTC) #5
oshima
https://codereview.chromium.org/923273003/diff/20001/ui/display/chromeos/display_configurator.h File ui/display/chromeos/display_configurator.h (right): https://codereview.chromium.org/923273003/diff/20001/ui/display/chromeos/display_configurator.h#newcode71 ui/display/chromeos/display_configurator.h:71: // displays that are deteced when faield. On 2015/02/23 ...
5 years, 10 months ago (2015-02-23 17:58:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923273003/80001
5 years, 10 months ago (2015-02-24 01:51:49 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 10 months ago (2015-02-24 01:58:53 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 01:59:59 UTC) #12
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/b2e4077d5c78430e973ffe58edbf925c7161c0c6
Cr-Commit-Position: refs/heads/master@{#317735}

Powered by Google App Engine
This is Rietveld 408576698