Enable crash keys for cast shell on android

Enable crash keys for cast shell on android

Allows using crash key system for android cast shell similiar to how
it's used for chrome

BUG=internal b/18763538

Committed: https://crrev.com/67a1b4521e9120433a0950b9f7248a6f7601e3b9
Cr-Commit-Position: refs/heads/master@{#316920}

[kjoswiak, 2015-02-14 02:15:00]

kjoswiak@chromium.org changed reviewers:
+ gunsch@chromium.org, lcwu@chromium.org

[gunsch, 2015-02-17 17:20:29]

https://codereview.chromium.org/923263004/diff/1/chromecast/android/cast_cras...
File chromecast/android/cast_crash_keys_android.h (right):

https://codereview.chromium.org/923263004/diff/1/chromecast/android/cast_cras...
chromecast/android/cast_crash_keys_android.h:5: #ifndef
CHROMECAST_ANDROID_CAST_CRASH_KEYS_ANDROID_H_
let's rename this file to be:

1) in chromecast/crash
2) not have "android" in the name

so we can reuse it later

[kjoswiak, 2015-02-17 20:03:29]

https://codereview.chromium.org/923263004/diff/1/chromecast/android/cast_cras...
File chromecast/android/cast_crash_keys_android.h (right):

https://codereview.chromium.org/923263004/diff/1/chromecast/android/cast_cras...
chromecast/android/cast_crash_keys_android.h:5: #ifndef
CHROMECAST_ANDROID_CAST_CRASH_KEYS_ANDROID_H_
On 2015/02/17 17:20:29, gunsch wrote:
> let's rename this file to be:
> 
> 1) in chromecast/crash
> 2) not have "android" in the name
> 
> so we can reuse it later

Done.

[gunsch, 2015-02-17 20:07:02]

lgtm

[gunsch, 2015-02-17 20:07:58]

https://codereview.chromium.org/923263004/diff/20001/chromecast/chromecast.gyp
File chromecast/chromecast.gyp (right):

https://codereview.chromium.org/923263004/diff/20001/chromecast/chromecast.gy...
chromecast/chromecast.gyp:361: 'crash/cast_crash_keys.cc',
ah wait, can you move these to cast_crash_client above? it's linked into
cast_shell_common so both ATV and Chromecast should get it.

[kjoswiak, 2015-02-17 20:48:07]

On 2015/02/17 20:07:58, gunsch wrote:
> https://codereview.chromium.org/923263004/diff/20001/chromecast/chromecast.gyp
> File chromecast/chromecast.gyp (right):
> 
>
https://codereview.chromium.org/923263004/diff/20001/chromecast/chromecast.gy...
> chromecast/chromecast.gyp:361: 'crash/cast_crash_keys.cc',
> ah wait, can you move these to cast_crash_client above? it's linked into
> cast_shell_common so both ATV and Chromecast should get it.

I was thinking for now leave them android specific, but Done.

[kjoswiak, 2015-02-17 20:50:59]

New patchsets have been uploaded after l-g-t-m from gunsch@chromium.org

[byungchul, 2015-02-18 19:09:03]

byungchul@chromium.org changed reviewers:
+ byungchul@chromium.org

[byungchul, 2015-02-18 19:09:04]

https://codereview.chromium.org/923263004/diff/40001/chromecast/crash/android...
File chromecast/crash/android/cast_crash_reporter_client_android.cc (right):

https://codereview.chromium.org/923263004/diff/40001/chromecast/crash/android...
chromecast/crash/android/cast_crash_reporter_client_android.cc:60: return
crash_keys::RegisterCastCrashKeys();
Do you plan to do same for all products?

https://codereview.chromium.org/923263004/diff/40001/chromecast/crash/cast_cr...
File chromecast/crash/cast_crash_keys.cc (right):

https://codereview.chromium.org/923263004/diff/40001/chromecast/crash/cast_cr...
chromecast/crash/cast_crash_keys.cc:26: static const size_t kSingleChunkLength =
63;
Please define them in an anonymous namespace.

[kjoswiak, 2015-02-18 19:46:51]

https://codereview.chromium.org/923263004/diff/40001/chromecast/crash/android...
File chromecast/crash/android/cast_crash_reporter_client_android.cc (right):

https://codereview.chromium.org/923263004/diff/40001/chromecast/crash/android...
chromecast/crash/android/cast_crash_reporter_client_android.cc:60: return
crash_keys::RegisterCastCrashKeys();
On 2015/02/18 19:09:03, byungchul wrote:
> Do you plan to do same for all products?

This is in consideration. Part of the problem I've run into is our crash
handling on chromecast and android are very different.

Android uses mostly default chrome path, which means crash keys make a lot of
sense and are the cleanest way to take care of meta data, whereas chromecast has
its own mostly custom system for crash handling that circumnavigates crash keys,
and instead uses a custom system for tracking metadata.

One of these systems should probably converge to the other, but I'm not sure
which

https://codereview.chromium.org/923263004/diff/40001/chromecast/crash/cast_cr...
File chromecast/crash/cast_crash_keys.cc (right):

https://codereview.chromium.org/923263004/diff/40001/chromecast/crash/cast_cr...
chromecast/crash/cast_crash_keys.cc:26: static const size_t kSingleChunkLength =
63;
On 2015/02/18 19:09:03, byungchul wrote:
> Please define them in an anonymous namespace.

Done.

[byungchul, 2015-02-18 19:49:18]

lgtm

[kjoswiak, 2015-02-18 23:01:34]

The CQ bit was checked by kjoswiak@chromium.org

[commit-bot: I haz the power, 2015-02-18 23:02:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/923263004/80001

[commit-bot: I haz the power, 2015-02-18 23:45:27]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-02-18 23:46:16]

Patchset 5 (id:??) landed as
https://crrev.com/67a1b4521e9120433a0950b9f7248a6f7601e3b9
Cr-Commit-Position: refs/heads/master@{#316920}