Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: ppapi/proxy/file_mapping_resource.cc

Issue 923263003: PPAPI: Make TrackedCallback more threadsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/ppapi_tests.gypi ('k') | ppapi/proxy/tracked_callback_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/file_mapping_resource.cc
diff --git a/ppapi/proxy/file_mapping_resource.cc b/ppapi/proxy/file_mapping_resource.cc
index c620c06dd29968620cce360a35868ee1fdd1dd66..b1dc27169f6f9fffa2aa2421283f4bbc0ac345c8 100644
--- a/ppapi/proxy/file_mapping_resource.cc
+++ b/ppapi/proxy/file_mapping_resource.cc
@@ -137,19 +137,7 @@ void FileMappingResource::OnMapCompleted(
int64_t length,
scoped_refptr<TrackedCallback> callback,
const MapResult& map_result) {
- if (callback->aborted()) {
- if (map_result.result == PP_OK) {
- // If the Map operation was successful, we need to Unmap to avoid leaks.
- // The plugin won't get the address, so doesn't have a chance to do the
- // Unmap.
- PpapiGlobals::Get()->GetFileTaskRunner()->PostTask(
- FROM_HERE,
- base::Bind(base::IgnoreResult(&FileMappingResource::DoUnmapBlocking),
- map_result.address,
- length));
- }
- return;
- }
+ // FIXME, just delete this whole file when merging.
dmichael (off chromium) 2015/02/27 22:04:40 When I can rebase this on top of removing FileMapp
bbudge 2015/03/05 01:29:35 OK.
if (map_result.result == PP_OK)
*mapped_address_out_param = map_result.address;
if (!callback->is_blocking())
« no previous file with comments | « ppapi/ppapi_tests.gypi ('k') | ppapi/proxy/tracked_callback_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698