PPAPI: Make TrackedCallback more threadsafe

ppapi/shared_impl/proxy_lock.h

Index: ppapi/shared_impl/proxy_lock.h
diff --git a/ppapi/shared_impl/proxy_lock.h b/ppapi/shared_impl/proxy_lock.h
index 39b653e1a00bccb49217f9b494d4d5a666d5a67d..7fcf2cf23b2958f661fd8748b57c3a1806cc26f3 100644
--- a/ppapi/shared_impl/proxy_lock.h
+++ b/ppapi/shared_impl/proxy_lock.h
@@ -175,9 +175,6 @@ class RunWhileLockedHelper<void()> {
   typedef base::Callback<void()> CallbackType;
   explicit RunWhileLockedHelper(const CallbackType& callback)
       : callback_(new CallbackType(callback)) {
-    // Copying |callback| may adjust reference counts for bound Vars or
-    // Resources; we should have the lock already.
-    ProxyLock::AssertAcquired();

[dmichael (off chromium), 2015/03/25 17:15:58]

I needed to be able to use RunWhileLocked on the IO thread without the
ProxyLock, and I realized that for a while now, VarTracker and ResourceTracker
do their own checking, so we should be protected from mistakes like binding a
ScopedPPVar without the ProxyLock...
https://code.google.com/p/chromium/codesearch#chromium/src/ppapi/shared_impl/...
https://code.google.com/p/chromium/codesearch#chromium/src/ppapi/shared_impl/...

     // CallWhileLocked and destruction might happen on a different thread from
     // creation.
     thread_checker_.DetachFromThread();
@@ -268,7 +265,6 @@ class RunWhileLockedHelper<void(P1, P2)> {
   typedef base::Callback<void(P1, P2)> CallbackType;
   explicit RunWhileLockedHelper(const CallbackType& callback)
       : callback_(new CallbackType(callback)) {
-    ProxyLock::AssertAcquired();
     thread_checker_.DetachFromThread();
   }
   void CallWhileLocked(P1 p1, P2 p2) {
@@ -298,7 +294,6 @@ class RunWhileLockedHelper<void(P1, P2, P3)> {
   typedef base::Callback<void(P1, P2, P3)> CallbackType;
   explicit RunWhileLockedHelper(const CallbackType& callback)
       : callback_(new CallbackType(callback)) {
-    ProxyLock::AssertAcquired();
     thread_checker_.DetachFromThread();
   }
   void CallWhileLocked(P1 p1, P2 p2, P3 p3) {