Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 923263002: Report HTTPS links in MalwareDetails (Closed)

Created:
5 years, 10 months ago by Nathan Parker
Modified:
5 years, 10 months ago
Reviewers:
noelutz, noé
CC:
chromium-reviews, grt+watch_chromium.org, battre
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Report HTTPS links in MalwareDetails. This is only sent if user has opted-in to malware-extended-reporting. BUG=447772, 342617 Committed: https://crrev.com/6f958fff1983fdb28abde7aba5d42afe7b86a428 Cr-Commit-Position: refs/heads/master@{#316654}

Patch Set 1 : Report HTTPS links in MalwareDetails #

Patch Set 2 : Lint nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -49 lines) Patch
M chrome/browser/safe_browsing/malware_details.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/malware_details.cc View 1 5 chunks +18 lines, -8 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details_unittest.cc View 1 8 chunks +27 lines, -40 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Nathan Parker
Dominic -- let me know if you don't want to be CC'd on these changes.
5 years, 10 months ago (2015-02-13 23:22:38 UTC) #2
noelutz
lgtm nice. Thanks, n.
5 years, 10 months ago (2015-02-17 21:13:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923263002/20001
5 years, 10 months ago (2015-02-17 21:24:34 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-17 21:28:53 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 21:29:36 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f958fff1983fdb28abde7aba5d42afe7b86a428
Cr-Commit-Position: refs/heads/master@{#316654}

Powered by Google App Engine
This is Rietveld 408576698