chrome/browser/chrome_content_browser_client.cc - Issue 923183003: Move URL fixup to a preliminary phase that doesn't affect virtual URLs.

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 923183003: Move URL fixup to a preliminary phase that doesn't affect virtual URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move to BrowserURLHandler Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/browser_about_handler.cc ('K') | « chrome/browser/browser_about_handler_unittest.cc ('k') | chrome/browser/sessions/session_restore_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index a0ad854e231c6296469b8ee2a44639cf5c3b6ea8..135e9db519dd3336585c110c154ade76e14a7b2e 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -104,6 +104,7 @@

#include "components/pref_registry/pref_registry_syncable.h"

#include "components/signin/core/common/profile_management_switches.h"

#include "components/translate/core/common/translate_switches.h"

+#include "components/url_fixer/url_fixer.h"

#include "content/public/browser/browser_child_process_host.h"

#include "content/public/browser/browser_main_parts.h"

#include "content/public/browser/browser_ppapi_host.h"

@@ -2261,7 +2262,8 @@ void ChromeContentBrowserClient::BrowserURLHandlerCreated(

// about: handler. Must come before chrome: handler, since it will

// rewrite about: urls to chrome: URLs and then expect chrome: to

- // actually handle them.

+ // actually handle them. Also relies on a preliminary fixup phase.

+ handler->SetFixupHandler(&FixupBrowserAboutURL);

msw 2015/02/18 22:01:23 Is it reasonable to just call AddHandlerPair with

Charlie Reis 2015/02/18 22:16:17 I don't think so, since all the handlers added by

handler->AddHandlerPair(&WillHandleBrowserAboutURL,

BrowserURLHandler::null_handler());