Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Side by Side Diff: chrome/browser/browser_about_handler.h

Issue 923183003: Move URL fixup to a preliminary phase that doesn't affect virtual URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move to BrowserURLHandler Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BROWSER_ABOUT_HANDLER_H_ 5 #ifndef CHROME_BROWSER_BROWSER_ABOUT_HANDLER_H_
6 #define CHROME_BROWSER_BROWSER_ABOUT_HANDLER_H_ 6 #define CHROME_BROWSER_BROWSER_ABOUT_HANDLER_H_
7 7
8 class GURL; 8 class GURL;
9 9
10 namespace content { 10 namespace content {
11 class BrowserContext; 11 class BrowserContext;
12 } 12 }
13 13
14 // A preliminary URLHandler that performs cleanup on the URL before it is
15 // rewritten. Changes that happen here will not lead to a virtual URL.
16 bool FixupBrowserAboutURL(GURL* url, content::BrowserContext* browser_context);
msw 2015/02/18 22:01:23 Looking through all the URLHandler code, I don't s
Charlie Reis 2015/02/18 22:16:17 Sadly, HandleNewTabURLRewrite and HandleNewTabURLR
17
14 // Returns true if the given URL will be handled by the browser about handler. 18 // Returns true if the given URL will be handled by the browser about handler.
15 // Nowadays, these go through the webui, so the return is always false. 19 // Nowadays, these go through the webui, so the return is always false.
16 // Either way, |url| will be processed by url_fixer::FixupURL, which 20 // Either way, |url| will be processed by url_fixer::FixupURL, which
17 // replaces the about: scheme with chrome:// for all about:foo URLs except 21 // replaces the about: scheme with chrome:// for all about:foo URLs except
18 // "about:blank". 22 // "about:blank".
19 // Some |url| host values will be replaced with their respective redirects. 23 // Some |url| host values will be replaced with their respective redirects.
20 // 24 //
21 // This is used by BrowserURLHandler. 25 // This is used by BrowserURLHandler.
22 bool WillHandleBrowserAboutURL(GURL* url, 26 bool WillHandleBrowserAboutURL(GURL* url,
23 content::BrowserContext* browser_context); 27 content::BrowserContext* browser_context);
24 28
25 // We have a few magic commands that don't cause navigations, but rather pop up 29 // We have a few magic commands that don't cause navigations, but rather pop up
26 // dialogs. This function handles those cases, and returns true if so. In this 30 // dialogs. This function handles those cases, and returns true if so. In this
27 // case, normal tab navigation should be skipped. 31 // case, normal tab navigation should be skipped.
28 bool HandleNonNavigationAboutURL(const GURL& url); 32 bool HandleNonNavigationAboutURL(const GURL& url);
29 33
30 #endif // CHROME_BROWSER_BROWSER_ABOUT_HANDLER_H_ 34 #endif // CHROME_BROWSER_BROWSER_ABOUT_HANDLER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/browser_about_handler.cc » ('j') | chrome/browser/browser_about_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698