Issue 923153003: Revert of Use dst copies in porter duffer XP to correctly render certain blends.

Issue 923153003: Revert of Use dst copies in porter duffer XP to correctly render certain blends. (Closed)

Created:
5 years, 10 months ago by egdaniel

Modified:
5 years, 10 months ago

Reviewers:
joshualitt, bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@prePDDstCopy

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Use dst copies in porter duffer XP to correctly render certain blends. (patchset #4 id:60001 of https://codereview.chromium.org/914003003/) Reason for revert: Failing GLProgramTest passing in stupid coeffs Original issue's description: > Use dst copies in porter duffer XP to correctly render certain blends. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/997c6358d94e188b1a7b89a4f86e24cbe0f5a164 TBR=bsalomon@google.com,joshualitt@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/2b816bacc0696f03d88c8060b21eda1e5cc7e8b1

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -193 lines)			Patch
M	include/gpu/GrXferProcessor.h	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	include/gpu/effects/GrPorterDuffXferProcessor.h	View	2 chunks	+4 lines, -8 lines	0 comments	Download
M	src/effects/SkArithmeticMode_gpu.h	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/effects/SkArithmeticMode_gpu.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/gpu/GrXferProcessor.cpp	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/gpu/effects/GrCoverageSetOpXP.h	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/gpu/effects/GrCoverageSetOpXP.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/gpu/effects/GrCustomXfermode.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/gpu/effects/GrCustomXfermodePriv.h	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/gpu/effects/GrDisableColorXP.h	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/gpu/effects/GrDisableColorXP.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/gpu/effects/GrPorterDuffXferProcessor.cpp	View	11 chunks	+66 lines, -152 lines	0 comments	Download

Total messages: 3 (0 generated)

egdaniel

Created Revert of Use dst copies in porter duffer XP to correctly render certain blends.

5 years, 10 months ago (2015-02-13 19:07:04 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923153003/1

5 years, 10 months ago (2015-02-13 19:07:45 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-13 19:07:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2b816bacc0696f03d88c8060b21eda1e5cc7e8b1