Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/browser/resources/pdf/navigator.js

Issue 923063002: Sample Patch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/pdf/open_pdf_params_parser.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/pdf/navigator.js
diff --git a/chrome/browser/resources/pdf/navigator.js b/chrome/browser/resources/pdf/navigator.js
index 57c15d4d26c47c983f83a839c766cb79d22f9dfe..48a89be0ea4b59ac241c7eba067bb779be29a8e7 100644
--- a/chrome/browser/resources/pdf/navigator.js
+++ b/chrome/browser/resources/pdf/navigator.js
@@ -74,12 +74,14 @@ Navigator.prototype = {
if (newTab) {
this.navigateInNewTabCallback_(url);
} else {
- var pageNumber =
- this.paramsParser_.getViewportFromUrlParams(url).page;
- if (pageNumber != undefined)
- this.viewport_.goToPage(pageNumber);
- else
- this.navigateInCurrentTabCallback_(url);
+ this.paramsParser_.getViewportFromUrlParams(
+ url, function(initialViewport) {
+ var pageNumber = initialViewport.pageNumber;
+ if (pageNumber != undefined)
+ this.viewport_.goToPage(pageNumber);
+ else
+ this.navigateInCurrentTabCallback_(url);
+ }.bind(this));
}
}
};
« no previous file with comments | « no previous file | chrome/browser/resources/pdf/open_pdf_params_parser.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698