mojo/public/tools/bindings/pylib/mojom/generate/pack.py - Issue 923033003: Implement unions as members of structs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/pylib/mojom/generate/pack.py

Issue 923033003: Implement unions as members of structs. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/tools/bindings/pylib/mojom/generate/pack.py

diff --git a/mojo/public/tools/bindings/pylib/mojom/generate/pack.py b/mojo/public/tools/bindings/pylib/mojom/generate/pack.py

index 4e522c97450ac06bf1f9bf1fabe13ac1f03896d3..9c72cfa8d0fbcfb69dc9797e146e85d13b301fa4 100644

--- a/mojo/public/tools/bindings/pylib/mojom/generate/pack.py

+++ b/mojo/public/tools/bindings/pylib/mojom/generate/pack.py

@@ -45,6 +45,8 @@ class PackedField(object):

def GetSizeForKind(cls, kind):

if isinstance(kind, (mojom.Array, mojom.Map, mojom.Struct)):

return 8

+ if isinstance(kind, mojom.Union):

+ return 16

if (isinstance(kind, mojom.Interface) or

isinstance(kind, mojom.InterfaceRequest)):

kind = mojom.MSGPIPE