Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Side by Side Diff: mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl

Issue 923033003: Implement unions as members of structs. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 size_t GetSerializedSize_(const {{union.name}}Ptr& input) { 1 size_t GetSerializedSize_(const {{union.name}}Ptr& input) {
2 size_t size = sizeof(internal::{{union.name}}_Data);
2 if (!input) 3 if (!input)
3 return 0; 4 return size;
4 5
5 size_t size = sizeof(internal::{{union.name}}_Data);
6 switch (input->which()) { 6 switch (input->which()) {
7 {% for field in union.fields %} 7 {% for field in union.fields %}
8 {% if field.kind|is_string_kind %} 8 {% if field.kind|is_string_kind %}
9 case {{union.name}}::Tag::{{field.name|upper}}: 9 case {{union.name}}::Tag::{{field.name|upper}}:
10 size += GetSerializedSize_(input->get_{{field.name}}()); 10 size += GetSerializedSize_(input->get_{{field.name}}());
11 break; 11 break;
12 {%- endif %} 12 {%- endif %}
13 {%- endfor %} 13 {%- endfor %}
14 default: 14 default:
15 break; 15 break;
16 } 16 }
17 return size; 17 return size;
18 } 18 }
19 19
20 20 void SerializeUnion_({{union.name}}Ptr input, mojo::internal::Buffer* buf,
21 void Serialize_({{union.name}}Ptr input, mojo::internal::Buffer* buf, 21 internal::{{union.name}}_Data** output, bool inlined) {
22 internal::{{union.name}}_Data** output) { 22 internal::{{union.name}}_Data* result = nullptr;
23 if (inlined) {
24 result = *output;
25 } else {
26 result = internal::{{union.name}}_Data::New(buf);
yzshen1 2015/03/27 16:26:33 If it is non-inlined, and input is nullptr, you do
azani 2015/03/27 20:50:14 I went with something a bit different, but same id
27 }
23 if (input) { 28 if (input) {
24 mojo::internal::UnionAccessor<{{union.name}}> input_acc(input.get()); 29 mojo::internal::UnionAccessor<{{union.name}}> input_acc(input.get());
25 internal::{{union.name}}_Data* result =
26 internal::{{union.name}}_Data::New(buf);
27 // TODO(azani): Handle unknown and objects. 30 // TODO(azani): Handle unknown and objects.
31 // Set the not-null flag.
32 result->size = 16;
28 result->tag = input->which(); 33 result->tag = input->which();
29 switch (input->which()) { 34 switch (input->which()) {
30 {% for field in union.fields %} 35 {% for field in union.fields %}
31 case {{union.name}}::Tag::{{field.name|upper}}: 36 case {{union.name}}::Tag::{{field.name|upper}}:
32 {% if field.kind|is_string_kind %} 37 {% if field.kind|is_string_kind %}
33 {{field.kind|cpp_field_type}}* {{field.name}}_ptr = reinterpret_cast<{{f ield.kind|cpp_field_type}}*>(&result->data.f_{{field.name}}); 38 {{field.kind|cpp_field_type}}* {{field.name}}_ptr = reinterpret_cast<{{f ield.kind|cpp_field_type}}*>(&result->data.f_{{field.name}});
34 Serialize_(*(input_acc.data()->{{field.name}}), buf, &{{field.name}}_ptr ->ptr); 39 Serialize_(*(input_acc.data()->{{field.name}}), buf, &{{field.name}}_ptr ->ptr);
35 {% else %} 40 {% else %}
36 result->data.f_{{field.name}} = input_acc.data()->{{field.name}}; 41 result->data.f_{{field.name}} = input_acc.data()->{{field.name}};
37 {%- endif %} 42 {%- endif %}
38 break; 43 break;
39 {%- endfor %} 44 {%- endfor %}
40 } 45 }
41 *output = result; 46 } else if (inlined) {
47 result->set_null();
42 } else { 48 } else {
43 *output = nullptr; 49 result = nullptr;
44 } 50 }
51 *output = result;
45 } 52 }
46 53
47 void Deserialize_(internal::{{union.name}}_Data* input, 54 void Deserialize_(internal::{{union.name}}_Data* input,
48 {{union.name}}Ptr* output) { 55 {{union.name}}Ptr* output) {
49 if (input) { 56 if (input && !input->is_null()) {
50 {{union.name}}Ptr result({{union.name}}::New()); 57 {{union.name}}Ptr result({{union.name}}::New());
51 mojo::internal::UnionAccessor<{{union.name}}> result_acc(result.get()); 58 mojo::internal::UnionAccessor<{{union.name}}> result_acc(result.get());
52 switch (input->tag) { 59 switch (input->tag) {
53 {% for field in union.fields %} 60 {% for field in union.fields %}
54 case {{union.name}}::Tag::{{field.name|upper}}: 61 case {{union.name}}::Tag::{{field.name|upper}}:
55 {% if field.kind|is_string_kind %} 62 {% if field.kind|is_string_kind %}
56 result_acc.SwitchActive({{union.name}}::Tag::{{field.name|upper}}); 63 result_acc.SwitchActive({{union.name}}::Tag::{{field.name|upper}});
57 {{field.kind|cpp_field_type}}* {{field.name}}_ptr = reinterpret_cast<{{f ield.kind|cpp_field_type}}*>(&input->data.f_{{field.name}}); 64 {{field.kind|cpp_field_type}}* {{field.name}}_ptr = reinterpret_cast<{{f ield.kind|cpp_field_type}}*>(&input->data.f_{{field.name}});
58 Deserialize_({{field.name}}_ptr->ptr, result_acc.data()->{{field.name}}) ; 65 Deserialize_({{field.name}}_ptr->ptr, result_acc.data()->{{field.name}}) ;
59 {% else %} 66 {% else %}
60 result->set_{{field.name}}(input->data.f_{{field.name}}); 67 result->set_{{field.name}}(input->data.f_{{field.name}});
61 {%- endif %} 68 {%- endif %}
62 break; 69 break;
63 {%- endfor %} 70 {%- endfor %}
64 } 71 }
65 *output = result.Pass(); 72 *output = result.Pass();
66 } else { 73 } else {
67 output->reset(); 74 output->reset();
68 } 75 }
69 } 76 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698