Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: sky/specs/events.md

Issue 923023005: Specs: Make appendChild, prependChild, and setChild return the child; make Dispatcher's unlisten() … (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/specs/elements.md ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/specs/events.md
diff --git a/sky/specs/events.md b/sky/specs/events.md
index 5194094bdf73feee1ce3c8a22245ebe246d1a921..18cbb33097a86795207d7e2796b72be917124112 100644
--- a/sky/specs/events.md
+++ b/sky/specs/events.md
@@ -55,7 +55,7 @@ class Dispatcher<T> {
var target = _listeners.lastWhere((v) => v.a == handler, orElse: () => null);
if (target == null)
return false;
- _listeners.remove(target);
+ _listeners.removeAt(_listeners.lastIndexOf(target));
return true;
}
void _add(T data) {
« no previous file with comments | « sky/specs/elements.md ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698