Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 923023003: Ensure import details popup is hidden by default. (Closed)

Created:
5 years, 10 months ago by Steve McKay
Modified:
5 years, 10 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure import details popup is hidden by default. BUG=458510 TEST=browser_test: *FileManager* Committed: https://crrev.com/acd3b0dbfced9c7ebf6399733aea43b51699bc31 Cr-Commit-Position: refs/heads/master@{#316395}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/file_manager/file_manager/main.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Steve McKay
5 years, 10 months ago (2015-02-13 18:52:10 UTC) #2
fukino
lgtm
5 years, 10 months ago (2015-02-14 07:14:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923023003/1
5 years, 10 months ago (2015-02-14 18:16:34 UTC) #5
Steve McKay
Thanks! And feel free to hit the commit checkbox for small changes like this. I ...
5 years, 10 months ago (2015-02-14 18:17:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/25400)
5 years, 10 months ago (2015-02-14 19:12:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923023003/1
5 years, 10 months ago (2015-02-14 19:17:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-14 20:06:01 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 20:06:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/acd3b0dbfced9c7ebf6399733aea43b51699bc31
Cr-Commit-Position: refs/heads/master@{#316395}

Powered by Google App Engine
This is Rietveld 408576698