Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 923023002: Refactoring code so as to avoid possible crash due to null pointer (Closed)

Created:
5 years, 10 months ago by Sunil Ratnu
Modified:
5 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Refactoring code so as to avoid possible crash due to null pointer In method InputMethodController::setCompositionFromExistingText we access the value of baseNode()->isTextNode() without checking whether baseNode is null or not. This could lead to a possible crash. Now, we have an additional check for baseNode before accessing baseNode()->isTextNode(). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/editing/InputMethodController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
rwlbuis
Change looks good, but adding some editing reviewers.
5 years, 10 months ago (2015-02-13 16:27:38 UTC) #2
tkent
-yutak, tkent +yosin
5 years, 10 months ago (2015-02-16 01:34:07 UTC) #4
Yuta Kitamura
LGTM, this makes sense.
5 years, 10 months ago (2015-02-16 10:59:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923023002/1
5 years, 10 months ago (2015-02-16 12:30:35 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/47144)
5 years, 10 months ago (2015-02-16 13:21:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923023002/1
5 years, 10 months ago (2015-02-16 13:26:56 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/47157)
5 years, 10 months ago (2015-02-16 14:12:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923023002/1
5 years, 10 months ago (2015-02-17 12:31:37 UTC) #16
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 14:02:50 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190318

Powered by Google App Engine
This is Rietveld 408576698