Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 923013004: Use offsetX and offsetY to position the fake mouse cursor. (Closed)

Created:
5 years, 10 months ago by Jamie
Modified:
5 years, 10 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use offsetX and offsetY to position the fake mouse cursor. The mouse cursor element is positioned relative to the document body (ie, ignoring the title bar for apps v2). However, its position was being set using the x and y coordinates of the mouse event, which are relative to the client viewport. This CL fixes this, using offsetX/Y, which are relative to the target element. BUG=410473 Committed: https://crrev.com/a19b19882cd9eff4696d0a081e6fc2f9b95f9c18 Cr-Commit-Position: refs/heads/master@{#317447}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M remoting/webapp/crd/js/desktop_connected_view.js View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jamie
ptal
5 years, 10 months ago (2015-02-20 19:36:14 UTC) #2
kelvinp
lgtm https://codereview.chromium.org/923013004/diff/1/remoting/webapp/crd/js/client_session.js File remoting/webapp/crd/js/client_session.js (right): https://codereview.chromium.org/923013004/diff/1/remoting/webapp/crd/js/client_session.js#newcode179 remoting/webapp/crd/js/client_session.js:179: img.style.top = event.offsetY + 'px'; Is this ToT? ...
5 years, 10 months ago (2015-02-20 21:46:22 UTC) #3
Jamie
https://codereview.chromium.org/923013004/diff/1/remoting/webapp/crd/js/client_session.js File remoting/webapp/crd/js/client_session.js (right): https://codereview.chromium.org/923013004/diff/1/remoting/webapp/crd/js/client_session.js#newcode179 remoting/webapp/crd/js/client_session.js:179: img.style.top = event.offsetY + 'px'; On 2015/02/20 21:46:22, kelvinp ...
5 years, 10 months ago (2015-02-20 22:46:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923013004/20001
5 years, 10 months ago (2015-02-20 22:46:38 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-21 00:42:15 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-21 00:42:47 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a19b19882cd9eff4696d0a081e6fc2f9b95f9c18
Cr-Commit-Position: refs/heads/master@{#317447}

Powered by Google App Engine
This is Rietveld 408576698