Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 922983002: Sort GN files under content (Closed)

Created:
5 years, 10 months ago by satorux1
Modified:
5 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sort GN files under content For tools/sort_sources.py to be useful, existing GYP files should be sorted. BUG=456014 TEST=everything should build as before Committed: https://crrev.com/7fa9d30aaac588e4576f72aeb7d1f275f48b56e2 Cr-Commit-Position: refs/heads/master@{#316415}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M content/browser/BUILD.gn View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/gpu/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M content/plugin/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M content/shell/BUILD.gn View 1 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
satorux1
PTAL
5 years, 10 months ago (2015-02-13 07:06:48 UTC) #2
jam
lgtm
5 years, 10 months ago (2015-02-13 16:54:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922983002/20001
5 years, 10 months ago (2015-02-16 00:42:07 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-16 00:45:01 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 00:45:50 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7fa9d30aaac588e4576f72aeb7d1f275f48b56e2
Cr-Commit-Position: refs/heads/master@{#316415}

Powered by Google App Engine
This is Rietveld 408576698