Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9409)

Unified Diff: components/translate/core/browser/translate_infobar_delegate.cc

Issue 922953002: Minor infobar cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resync Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/translate/core/browser/translate_infobar_delegate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/translate/core/browser/translate_infobar_delegate.cc
diff --git a/components/translate/core/browser/translate_infobar_delegate.cc b/components/translate/core/browser/translate_infobar_delegate.cc
index 0d68e1381f98eb575bb39c1f11ecdc496c878ee0..56bf4de83ad681b09b2a649b4e12dfc4021954a3 100644
--- a/components/translate/core/browser/translate_infobar_delegate.cc
+++ b/components/translate/core/browser/translate_infobar_delegate.cc
@@ -268,6 +268,14 @@ bool TranslateInfoBarDelegate::ShouldShowAlwaysTranslateShortcut() {
kAlwaysTranslateMinCount);
}
+#if defined(OS_IOS)
+void TranslateInfoBarDelegate::ShowNeverTranslateInfobar() {
+ Create(true, translate_manager_, infobar()->owner(), is_off_the_record_,
+ translate::TRANSLATE_STEP_NEVER_TRANSLATE, original_language_code(),
+ target_language_code(), TranslateErrors::NONE, false);
+}
+#endif
+
// static
void TranslateInfoBarDelegate::GetAfterTranslateStrings(
std::vector<base::string16>* strings,
@@ -336,24 +344,15 @@ TranslateInfoBarDelegate::TranslateInfoBarDelegate(
background_animation_ = is_error() ? NORMAL_TO_ERROR : ERROR_TO_NORMAL;
}
-void TranslateInfoBarDelegate::InfoBarDismissed() {
- if (step_ != translate::TRANSLATE_STEP_BEFORE_TRANSLATE)
- return;
-
- // The user closed the infobar without clicking the translate button.
- TranslationDeclined();
- UMA_HISTOGRAM_BOOLEAN("Translate.DeclineTranslateCloseInfobar", true);
+infobars::InfoBarDelegate::Type
+TranslateInfoBarDelegate::GetInfoBarType() const {
+ return PAGE_ACTION_TYPE;
}
int TranslateInfoBarDelegate::GetIconID() const {
return translate_manager_->translate_client()->GetInfobarIconID();
}
-infobars::InfoBarDelegate::Type TranslateInfoBarDelegate::GetInfoBarType()
- const {
- return PAGE_ACTION_TYPE;
-}
-
bool TranslateInfoBarDelegate::ShouldExpire(
const NavigationDetails& details) const {
// Note: we allow closing this infobar even if the main frame navigation
@@ -364,17 +363,18 @@ bool TranslateInfoBarDelegate::ShouldExpire(
return infobars::InfoBarDelegate::ShouldExpireInternal(details);
}
+void TranslateInfoBarDelegate::InfoBarDismissed() {
+ if (step_ != translate::TRANSLATE_STEP_BEFORE_TRANSLATE)
+ return;
+
+ // The user closed the infobar without clicking the translate button.
+ TranslationDeclined();
+ UMA_HISTOGRAM_BOOLEAN("Translate.DeclineTranslateCloseInfobar", true);
+}
+
TranslateInfoBarDelegate*
TranslateInfoBarDelegate::AsTranslateInfoBarDelegate() {
return this;
}
-#if defined(OS_IOS)
-void TranslateInfoBarDelegate::ShowNeverTranslateInfobar() {
- Create(true, translate_manager_, infobar()->owner(), is_off_the_record_,
- translate::TRANSLATE_STEP_NEVER_TRANSLATE, original_language_code(),
- target_language_code(), TranslateErrors::NONE, false);
-}
-#endif
-
} // namespace translate
« no previous file with comments | « components/translate/core/browser/translate_infobar_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698