Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2604)

Unified Diff: chrome/browser/plugins/plugin_infobar_delegates.cc

Issue 922953002: Minor infobar cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resync Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/plugins/plugin_infobar_delegates.h ('k') | chrome/browser/ssl/ssl_add_certificate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugins/plugin_infobar_delegates.cc
diff --git a/chrome/browser/plugins/plugin_infobar_delegates.cc b/chrome/browser/plugins/plugin_infobar_delegates.cc
index ead6040bed8f8beb53926de08f026098cc67de88..15d7b048d498afdd9058a2a520a3551c171775cf 100644
--- a/chrome/browser/plugins/plugin_infobar_delegates.cc
+++ b/chrome/browser/plugins/plugin_infobar_delegates.cc
@@ -135,8 +135,8 @@ OutdatedPluginInfoBarDelegate::~OutdatedPluginInfoBarDelegate() {
content::RecordAction(UserMetricsAction("OutdatedPluginInfobar.Closed"));
}
-std::string OutdatedPluginInfoBarDelegate::GetLearnMoreURL() const {
- return chrome::kOutdatedPluginLearnMoreURL;
+void OutdatedPluginInfoBarDelegate::InfoBarDismissed() {
+ content::RecordAction(UserMetricsAction("OutdatedPluginInfobar.Dismissed"));
}
base::string16 OutdatedPluginInfoBarDelegate::GetMessageText() const {
@@ -172,16 +172,16 @@ bool OutdatedPluginInfoBarDelegate::Cancel() {
return true;
}
-void OutdatedPluginInfoBarDelegate::InfoBarDismissed() {
- content::RecordAction(UserMetricsAction("OutdatedPluginInfobar.Dismissed"));
-}
-
bool OutdatedPluginInfoBarDelegate::LinkClicked(
WindowOpenDisposition disposition) {
content::RecordAction(UserMetricsAction("OutdatedPluginInfobar.LearnMore"));
return PluginInfoBarDelegate::LinkClicked(disposition);
}
+std::string OutdatedPluginInfoBarDelegate::GetLearnMoreURL() const {
+ return chrome::kOutdatedPluginLearnMoreURL;
+}
+
void OutdatedPluginInfoBarDelegate::DownloadStarted() {
ReplaceWithInfoBar(l10n_util::GetStringFUTF16(IDS_PLUGIN_DOWNLOADING,
plugin_metadata_->name()));
« no previous file with comments | « chrome/browser/plugins/plugin_infobar_delegates.h ('k') | chrome/browser/ssl/ssl_add_certificate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698