Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2057)

Unified Diff: chrome/browser/password_manager/save_password_infobar_delegate.cc

Issue 922953002: Minor infobar cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resync Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/save_password_infobar_delegate.cc
diff --git a/chrome/browser/password_manager/save_password_infobar_delegate.cc b/chrome/browser/password_manager/save_password_infobar_delegate.cc
index 09f925d6d12a00729dd55262b0d15e2fff23e30f..98304991444881185072eb31ffaab2fff39e4443 100644
--- a/chrome/browser/password_manager/save_password_infobar_delegate.cc
+++ b/chrome/browser/password_manager/save_password_infobar_delegate.cc
@@ -92,19 +92,29 @@ SavePasswordInfoBarDelegate::SavePasswordInfoBarDelegate(
}
}
-bool SavePasswordInfoBarDelegate::ShouldExpire(
- const NavigationDetails& details) const {
- return !details.is_redirect &&
- infobars::InfoBarDelegate::ShouldExpire(details);
+infobars::InfoBarDelegate::Type
+SavePasswordInfoBarDelegate::GetInfoBarType() const {
+ return PAGE_ACTION_TYPE;
+}
+
+infobars::InfoBarDelegate::InfoBarAutomationType
+SavePasswordInfoBarDelegate::GetInfoBarAutomationType() const {
+ return PASSWORD_INFOBAR;
}
int SavePasswordInfoBarDelegate::GetIconID() const {
return IDR_INFOBAR_SAVE_PASSWORD;
}
-infobars::InfoBarDelegate::Type SavePasswordInfoBarDelegate::GetInfoBarType()
- const {
- return PAGE_ACTION_TYPE;
+bool SavePasswordInfoBarDelegate::ShouldExpire(
+ const NavigationDetails& details) const {
+ return !details.is_redirect &&
+ infobars::InfoBarDelegate::ShouldExpire(details);
+}
+
+void SavePasswordInfoBarDelegate::InfoBarDismissed() {
+ DCHECK(form_to_save_.get());
+ infobar_response_ = password_manager::metrics_util::INFOBAR_DISMISSED;
}
base::string16 SavePasswordInfoBarDelegate::GetMessageText() const {
@@ -130,13 +140,3 @@ bool SavePasswordInfoBarDelegate::Cancel() {
infobar_response_ = password_manager::metrics_util::NEVER_REMEMBER_PASSWORD;
return true;
}
-
-void SavePasswordInfoBarDelegate::InfoBarDismissed() {
- DCHECK(form_to_save_.get());
- infobar_response_ = password_manager::metrics_util::INFOBAR_DISMISSED;
-}
-
-infobars::InfoBarDelegate::InfoBarAutomationType
-SavePasswordInfoBarDelegate::GetInfoBarAutomationType() const {
- return PASSWORD_INFOBAR;
-}
« no previous file with comments | « chrome/browser/password_manager/save_password_infobar_delegate.h ('k') | chrome/browser/plugins/plugin_infobar_delegates.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698