Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Unified Diff: components/translate/core/browser/translate_infobar_delegate.cc

Issue 922953002: Minor infobar cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resync Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_infobar_delegate.cc
diff --git a/components/translate/core/browser/translate_infobar_delegate.cc b/components/translate/core/browser/translate_infobar_delegate.cc
index 0d68e1381f98eb575bb39c1f11ecdc496c878ee0..198ced81f187669edf64e626cb2efd73a403d6ec 100644
--- a/components/translate/core/browser/translate_infobar_delegate.cc
+++ b/components/translate/core/browser/translate_infobar_delegate.cc
@@ -268,6 +268,14 @@ bool TranslateInfoBarDelegate::ShouldShowAlwaysTranslateShortcut() {
kAlwaysTranslateMinCount);
}
+#if defined(OS_IOS)
+void TranslateInfoBarDelegate::ShowNeverTranslateInfobar() {
+ Create(true, translate_manager_, infobar()->owner(), is_off_the_record_,
+ translate::TRANSLATE_STEP_NEVER_TRANSLATE, original_language_code(),
+ target_language_code(), TranslateErrors::NONE, false);
+}
+#endif
+
// static
void TranslateInfoBarDelegate::GetAfterTranslateStrings(
std::vector<base::string16>* strings,
@@ -345,12 +353,8 @@ void TranslateInfoBarDelegate::InfoBarDismissed() {
UMA_HISTOGRAM_BOOLEAN("Translate.DeclineTranslateCloseInfobar", true);
}
-int TranslateInfoBarDelegate::GetIconID() const {
- return translate_manager_->translate_client()->GetInfobarIconID();
-}
-
-infobars::InfoBarDelegate::Type TranslateInfoBarDelegate::GetInfoBarType()
- const {
+infobars::InfoBarDelegate::Type
+TranslateInfoBarDelegate::GetInfoBarType() const {
return PAGE_ACTION_TYPE;
}
@@ -369,12 +373,8 @@ TranslateInfoBarDelegate*
return this;
}
-#if defined(OS_IOS)
-void TranslateInfoBarDelegate::ShowNeverTranslateInfobar() {
- Create(true, translate_manager_, infobar()->owner(), is_off_the_record_,
- translate::TRANSLATE_STEP_NEVER_TRANSLATE, original_language_code(),
- target_language_code(), TranslateErrors::NONE, false);
+int TranslateInfoBarDelegate::GetIconID() const {
+ return translate_manager_->translate_client()->GetInfobarIconID();
}
-#endif
} // namespace translate

Powered by Google App Engine
This is Rietveld 408576698