Minor infobar cleanup.

Minor infobar cleanup.

* Stop calling GetIconID() as a proxy for having RTTI to detect
  ThreeDAPIInfoBarDelegates.  Just add a downcast function.
* Slightly more reasonable base class function order.
* Fix declaration/definition orders to match base class (and each other) in
  other instances where it was noticeably wrong.
* Keep infobar code consistent about not inlining method definitions in class
  declarations, and making overridden functions private unless otherwise
  necessary.

BUG=none
TEST=none

Committed: https://crrev.com/bdbf3b186bc3fc0a1101b0571af80254fac9948f
Cr-Commit-Position: refs/heads/master@{#317685}

[Peter Kasting, 2015-02-13 03:22:25]

pkasting@chromium.org changed reviewers:
+ jochen@chromium.org

[Peter Kasting, 2015-02-13 03:22:26]

https://codereview.chromium.org/922953002/diff/20001/chrome/browser/content_s...
File chrome/browser/content_settings/permission_infobar_delegate.h (left):

https://codereview.chromium.org/922953002/diff/20001/chrome/browser/content_s...
chrome/browser/content_settings/permission_infobar_delegate.h:31: base::string16
GetMessageText() const override = 0;
This is already pure in the base class, so there's no need to redeclare it here,
the compiler will still enforce that subclasses override this.

https://codereview.chromium.org/922953002/diff/20001/chrome/browser/content_s...
chrome/browser/content_settings/permission_infobar_delegate.h:37: // overriding
them.
No one overrides these, so no need for a comment.

[Peter Kasting, 2015-02-13 03:29:30]

Wait on reviewing this; clearly codesearch did not find all the Android
craziness, so I need to think about what (if anything) can be done after taking
that into account.

[Peter Kasting, 2015-02-14 02:03:06]

OK, this is hopefully ready for review (fingers crossed).

[Peter Kasting, 2015-02-19 22:09:21]

Ping

[jochen (gone - plz use gerrit), 2015-02-23 12:08:55]

lgtm

[Peter Kasting, 2015-02-23 20:54:15]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2015-02-23 20:54:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/922953002/60001

[commit-bot: I haz the power, 2015-02-23 21:18:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 21:18:20]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Peter Kasting, 2015-02-23 21:46:34]

The CQ bit was checked by pkasting@chromium.org

[Peter Kasting, 2015-02-23 21:46:35]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/922953002/#ps80001 (title:
"Resync")

[commit-bot: I haz the power, 2015-02-23 21:47:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/922953002/80001

[commit-bot: I haz the power, 2015-02-24 00:19:17]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-02-24 00:20:14]

Patchset 5 (id:??) landed as
https://crrev.com/bdbf3b186bc3fc0a1101b0571af80254fac9948f
Cr-Commit-Position: refs/heads/master@{#317685}