Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 922923002: ui: Cleanup the usage of scoped_ptr throughout. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, ozone-reviews_chromium.org, derat+watch_chromium.org, tdresser+watch_chromium.org, tfarina, stevenjb+watch_chromium.org, oshima+watch_chromium.org, kalyank, peter+watch_chromium.org, jdduke+watch_chromium.org, mlamouri+watch-notifications_chromium.org, danakj, M-A Ruel, tapted
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: Cleanup the usage of scoped_ptr throughout. * Makes use make_scoped_ptr() when possible (less typing/noise). Entries found with the following command line: $ git grep -E '(=|\breturn)\s*scoped_ptr<.*?>([^)]+)' ui/ BUG=None R=sky@chromium.org Committed: https://crrev.com/9b6edf35dd1591b034995589f6cec89ec2863b38 Cr-Commit-Position: refs/heads/master@{#317131}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -42 lines) Patch
M ui/app_list/search/mixer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/chromeos/touch_exploration_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/display/chromeos/x11/display_configurator_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/event.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M ui/events/ozone/device/device_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/platform/x11/x11_event_source_glib.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/events/platform/x11/x11_event_source_libevent.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/events/test/test_event_target.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/render_text_harfbuzz.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/render_text_mac.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/message_center/message_center_tray.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/native_theme/common_theme.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/demo/ozone_demo.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/caca/ozone_platform_caca.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/dri_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/dri_surface_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/gbm_surface_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/gbm_surfaceless.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/ozone_platform_dri.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/ozone_platform_gbm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/egltest/ozone_platform_egltest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/test/ozone_platform_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/touch_selection/touch_handle_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/touch_selection/touch_selection_controller_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/test/widget_test_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
tfarina
The presubmit to catch this is in CL https://codereview.chromium.org/919253002/.
5 years, 10 months ago (2015-02-13 01:41:07 UTC) #1
tfarina
Sadrul, do you mind review this while Scott is OOO?
5 years, 10 months ago (2015-02-18 22:12:50 UTC) #3
sadrul
lgtm
5 years, 10 months ago (2015-02-19 17:20:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922923002/1
5 years, 10 months ago (2015-02-19 19:19:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/37219) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 10 months ago (2015-02-19 19:25:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922923002/20001
5 years, 10 months ago (2015-02-19 19:44:56 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 20:56:57 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 20:57:46 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9b6edf35dd1591b034995589f6cec89ec2863b38
Cr-Commit-Position: refs/heads/master@{#317131}

Powered by Google App Engine
This is Rietveld 408576698