Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 922903002: Enables ASAN build and test for Dart (Closed)

Created:
5 years, 10 months ago by zra
Modified:
5 years, 10 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Enables ASAN build and test for Dart After this change from koda@ [1], the Dart VM can run with the 'detect_stack_use_after_return' ASAN flag. [1] https://codereview.chromium.org/944783002/ BUG= R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/cc43905ec427a4b224d5df776c5896c53082cf01

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -19 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/BUILD.gn View 1 2 3 2 chunks +2 lines, -7 lines 0 comments Download
M mojo/tools/data/apptests View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/tools/data/unittests View 1 1 chunk +2 lines, -2 lines 0 comments Download
M services/BUILD.gn View 1 2 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
zra
5 years, 10 months ago (2015-02-13 16:40:15 UTC) #2
jamesr
We snapshot sanitizer_options.cc from chromium so your changed here will be blown away by the ...
5 years, 10 months ago (2015-02-13 16:55:26 UTC) #3
zra
On 2015/02/13 16:55:26, jamesr wrote: > We snapshot sanitizer_options.cc from chromium so your changed here ...
5 years, 10 months ago (2015-02-13 17:41:53 UTC) #4
jamesr
OK. We can change what this file does but it's more complex than simply patching ...
5 years, 10 months ago (2015-02-13 18:24:17 UTC) #5
zra
PTAL
5 years, 10 months ago (2015-02-23 20:56:01 UTC) #6
jamesr
lgtm (please send tryjobs with patches - 'git cl try') https://codereview.chromium.org/922903002/diff/40001/mojo/BUILD.gn File mojo/BUILD.gn (right): https://codereview.chromium.org/922903002/diff/40001/mojo/BUILD.gn#newcode81 ...
5 years, 10 months ago (2015-02-23 21:00:05 UTC) #7
zra
Thanks. https://codereview.chromium.org/922903002/diff/40001/mojo/BUILD.gn File mojo/BUILD.gn (right): https://codereview.chromium.org/922903002/diff/40001/mojo/BUILD.gn#newcode81 mojo/BUILD.gn:81: "//mojo/dart/embedder/test:dart_unittests", On 2015/02/23 21:00:05, jamesr wrote: > can ...
5 years, 10 months ago (2015-02-23 21:03:57 UTC) #8
zra
5 years, 10 months ago (2015-02-23 22:06:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
cc43905ec427a4b224d5df776c5896c53082cf01 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698