Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: sky/tools/webkitpy/bindings/main.py

Issue 922893002: Merge the Sky Engine changes from the SkyDart branch (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/tests/styles/media-queries-expected.txt ('k') | sky/viewer/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/webkitpy/bindings/main.py
diff --git a/sky/tools/webkitpy/bindings/main.py b/sky/tools/webkitpy/bindings/main.py
index d09023fd9b27c58dda3fec68edc2b3c546c7e1f1..49a48aa29d50fe1f4194a08ba5fee75c9032d906 100644
--- a/sky/tools/webkitpy/bindings/main.py
+++ b/sky/tools/webkitpy/bindings/main.py
@@ -43,7 +43,7 @@ import bindings.scripts.compute_interfaces_info_individual
from bindings.scripts.compute_interfaces_info_individual import compute_info_individual, info_individual
import bindings.scripts.compute_interfaces_info_overall
from bindings.scripts.compute_interfaces_info_overall import compute_interfaces_info_overall, interfaces_info
-from bindings.scripts.idl_compiler import IdlCompilerDictionaryImpl, IdlCompilerV8
+from bindings.scripts.idl_compiler import IdlCompilerV8
PASS_MESSAGE = 'All tests PASS!'
@@ -192,9 +192,6 @@ def bindings_tests(output_directory, verbose):
idl_compiler = IdlCompilerV8(output_directory,
interfaces_info=interfaces_info,
only_if_changed=True)
- dictionary_impl_compiler = IdlCompilerDictionaryImpl(
- output_directory, interfaces_info=interfaces_info,
- only_if_changed=True)
idl_basenames = [filename
for filename in os.listdir(test_input_directory)
@@ -207,9 +204,6 @@ def bindings_tests(output_directory, verbose):
os.path.join(test_input_directory, idl_basename))
idl_compiler.compile_file(idl_path)
definition_name, _ = os.path.splitext(idl_basename)
- if (definition_name in interfaces_info and
- interfaces_info[definition_name]['is_dictionary']):
- dictionary_impl_compiler.compile_file(idl_path)
if verbose:
print 'Compiled: %s' % filename
finally:
« no previous file with comments | « sky/tests/styles/media-queries-expected.txt ('k') | sky/viewer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698