sky/engine/web/WebElement.cpp - Issue 922893002: Merge the Sky Engine changes from the SkyDart branch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/web/WebElement.cpp

Issue 922893002: Merge the Sky Engine changes from the SkyDart branch (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/web/WebElement.cpp

diff --git a/sky/engine/web/WebElement.cpp b/sky/engine/web/WebElement.cpp

index 78273334611d304d3d1cad8600996730cc90f030..4aa25ae1483979347fc5f939c0d86d512fb613aa 100644

--- a/sky/engine/web/WebElement.cpp

+++ b/sky/engine/web/WebElement.cpp

@@ -31,7 +31,7 @@

#include "sky/engine/config.h"

#include "sky/engine/public/web/WebElement.h"

-#include "sky/engine/bindings/core/v8/ExceptionState.h"

+#include "sky/engine/bindings2/exception_state.h"

#include "sky/engine/core/dom/Element.h"

#include "sky/engine/core/dom/custom/CustomElementProcessingStack.h"

#include "sky/engine/core/dom/shadow/ShadowRoot.h"

@@ -73,7 +73,7 @@ bool WebElement::setAttribute(const WebString& attrName, const WebString& attrVa

CustomElementProcessingStack::CallbackDeliveryScope deliverCustomElementCallbacks;

TrackExceptionState exceptionState;

unwrap<Element>()->setAttribute(attrName, attrValue, exceptionState);

- return !exceptionState.hadException();

+ return !exceptionState.had_exception();

}

unsigned WebElement::attributeCount() const

« no previous file with comments | « sky/engine/web/WebDocument.cpp ('k') | sky/engine/web/WebLeakDetector.cpp » ('j') | no next file with comments »