Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: sky/engine/public/web/WebFrameClient.h

Issue 922893002: Merge the Sky Engine changes from the SkyDart branch (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/public/web/WebFrame.h ('k') | sky/engine/public/web/WebLeakDetector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/public/web/WebFrameClient.h
diff --git a/sky/engine/public/web/WebFrameClient.h b/sky/engine/public/web/WebFrameClient.h
index 6f4f12b5ebb64aeba05f6883a9f6e74841e6415b..5954d972fd99402a66064451025ba90ed733f2f3 100644
--- a/sky/engine/public/web/WebFrameClient.h
+++ b/sky/engine/public/web/WebFrameClient.h
@@ -39,7 +39,8 @@
#include "sky/engine/public/web/WebNavigationPolicy.h"
#include "sky/engine/public/web/WebNavigationType.h"
#include "sky/engine/public/web/WebTextDirection.h"
-#include "v8/include/v8.h"
+
+typedef struct _Dart_Isolate* Dart_Isolate;
namespace mojo {
class View;
@@ -86,6 +87,7 @@ public:
// Called when a watched CSS selector matches or stops matching.
virtual void didMatchCSS(WebLocalFrame*, const WebVector<WebString>& newlyMatchingSelectors, const WebVector<WebString>& stoppedMatchingSelectors) { }
+ virtual void didCreateIsolate(WebLocalFrame*, Dart_Isolate isolate) {}
// Console messages ----------------------------------------------------
@@ -196,16 +198,6 @@ public:
virtual void didLoadResourceFromMemoryCache(
WebLocalFrame*, const WebURLRequest&, const WebURLResponse&) { }
- // Script notifications ------------------------------------------------
-
- // Notifies that a new script context has been created for this frame.
- // This is similar to didClearWindowObject but only called once per
- // frame context.
- virtual void didCreateScriptContext(WebLocalFrame*, v8::Handle<v8::Context>) { }
-
- // WebKit is about to release its reference to a v8 context for a frame.
- virtual void willReleaseScriptContext(WebLocalFrame*, v8::Handle<v8::Context>) { }
-
// Geometry notifications ----------------------------------------------
« no previous file with comments | « sky/engine/public/web/WebFrame.h ('k') | sky/engine/public/web/WebLeakDetector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698