Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1457)

Unified Diff: sky/engine/core/events/ErrorEvent.cpp

Issue 922893002: Merge the Sky Engine changes from the SkyDart branch (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/events/ErrorEvent.h ('k') | sky/engine/core/events/ErrorEvent.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/events/ErrorEvent.cpp
diff --git a/sky/engine/core/events/ErrorEvent.cpp b/sky/engine/core/events/ErrorEvent.cpp
index 90c5676824ebc0a62d7ba767ec75e292695fa935..a5c9ea81cf951e12c8ecd6ead49b3ea6f26c73b2 100644
--- a/sky/engine/core/events/ErrorEvent.cpp
+++ b/sky/engine/core/events/ErrorEvent.cpp
@@ -31,9 +31,6 @@
#include "sky/engine/config.h"
#include "sky/engine/core/events/ErrorEvent.h"
-#include "sky/engine/bindings/core/v8/V8Binding.h"
-#include "v8/include/v8.h"
-
namespace blink {
ErrorEventInit::ErrorEventInit()
@@ -49,7 +46,6 @@ ErrorEvent::ErrorEvent()
, m_fileName()
, m_lineNumber(0)
, m_columnNumber(0)
- , m_world(DOMWrapperWorld::current(v8::Isolate::GetCurrent()))
{
}
@@ -59,17 +55,15 @@ ErrorEvent::ErrorEvent(const AtomicString& type, const ErrorEventInit& initializ
, m_fileName(initializer.filename)
, m_lineNumber(initializer.lineno)
, m_columnNumber(initializer.colno)
- , m_world(DOMWrapperWorld::current(v8::Isolate::GetCurrent()))
{
}
-ErrorEvent::ErrorEvent(const String& message, const String& fileName, unsigned lineNumber, unsigned columnNumber, DOMWrapperWorld* world)
+ErrorEvent::ErrorEvent(const String& message, const String& fileName, unsigned lineNumber, unsigned columnNumber)
: Event(EventTypeNames::error, false, true)
, m_sanitizedMessage(message)
, m_fileName(fileName)
, m_lineNumber(lineNumber)
, m_columnNumber(columnNumber)
- , m_world(world)
{
}
« no previous file with comments | « sky/engine/core/events/ErrorEvent.h ('k') | sky/engine/core/events/ErrorEvent.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698