sky/engine/build/scripts/name_macros.py - Issue 922893002: Merge the Sky Engine changes from the SkyDart branch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/build/scripts/name_macros.py

Issue 922893002: Merge the Sky Engine changes from the SkyDart branch (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/build/scripts/name_macros.py

diff --git a/sky/engine/build/scripts/name_macros.py b/sky/engine/build/scripts/name_macros.py

index cebc50c58d9d22b749a65a011ed215b7e54a9942..f6c114933988621cd3493bd3f18d98d4e3412914 100644

--- a/sky/engine/build/scripts/name_macros.py

+++ b/sky/engine/build/scripts/name_macros.py

@@ -131,14 +131,8 @@ class Writer(in_generator.Writer):

# Avoid duplicate includes.

if cpp_name in includes:

continue

- if self.suffix == 'Modules':

- subdir_name = 'modules'

- else:

- subdir_name = 'core'

- include = '#include "%(path)s"\n#include "bindings/%(subdir_name)s/v8/V8%(script_name)s.h"' % {

+ include = '#include "%(path)s"\n' % {

'path': self._headers_header_include_path(entry),

- 'script_name': name_utilities.script_name(entry),

- 'subdir_name': subdir_name,

}

includes[cpp_name] = self.wrap_with_condition(include, entry['Conditional'])

return includes.values()

« no previous file with comments | « sky/engine/bindings2/mojo_natives.cc ('k') | sky/engine/core/BUILD.gn » ('j') | no next file with comments »