Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 922873002: I cannot remember what the race here actually was. (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 10 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

I cannot remember what the race here actually was. Removing SkTRacy will show us, or perhaps show us we already fixed the race. BUG=chromium:437511 No public API changes. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/71409c83e69b387b3c5d567197d0421c36baf68d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -21 lines) Patch
M include/core/SkDynamicAnnotations.h View 1 chunk +0 lines, -19 lines 0 comments Download
M include/core/SkPixelRef.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
mtklein_C
5 years, 10 months ago (2015-02-12 22:03:51 UTC) #2
mtklein
lgtm
5 years, 10 months ago (2015-02-12 22:56:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922873002/1
5 years, 10 months ago (2015-02-12 22:56:44 UTC) #6
commit-bot: I haz the power
Presubmit check for 922873002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 10 months ago (2015-02-12 22:56:48 UTC) #8
bungeman-skia
On 2015/02/12 22:56:28, mtklein wrote: > lgtm lctm (looks crazy to me?) lgtm
5 years, 10 months ago (2015-02-12 22:57:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922873002/1
5 years, 10 months ago (2015-02-12 23:05:44 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/71409c83e69b387b3c5d567197d0421c36baf68d
5 years, 10 months ago (2015-02-12 23:24:56 UTC) #12
mtklein
5 years, 10 months ago (2015-02-12 23:31:50 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/923543003/ by mtklein@google.com.

The reason for reverting is:
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x....

Powered by Google App Engine
This is Rietveld 408576698