Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issue 922833004: Make PrinterProviderAPI a pure interface (Closed)

Created:
5 years, 10 months ago by tbarzic
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make PrinterProviderAPI a pure interface This makes PrinterProviderAPI a pure interface, with the implementation hidden in printer_provider.cc, and with a custom browser context keyed service factory. This will make it easier to inject a fake API implementation in tests (e.g. for ExtensionPrinterHandler). BUG=461114 TEST=extensions_browsertests --gtest_filter=PrinterProviderAPI Committed: https://crrev.com/1378bc38c7b711ec75bcf38c07292326f051015d Cr-Commit-Position: refs/heads/master@{#318124}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : missing files #

Patch Set 4 : . #

Messages

Total messages: 8 (2 generated)
tbarzic
Mostly moving code around rockot: owner review for gypi file
5 years, 10 months ago (2015-02-25 20:35:15 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 10 months ago (2015-02-25 20:39:59 UTC) #3
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 10 months ago (2015-02-25 20:55:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922833004/60001
5 years, 10 months ago (2015-02-25 20:57:05 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-25 21:41:35 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 21:42:43 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1378bc38c7b711ec75bcf38c07292326f051015d
Cr-Commit-Position: refs/heads/master@{#318124}

Powered by Google App Engine
This is Rietveld 408576698