Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 922833002: Cosmetic changes (spelling, grammar) and fix an annoyance. (Closed)

Created:
5 years, 10 months ago by dougk
Modified:
5 years, 10 months ago
Reviewers:
brettw, davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cosmetic changes (spelling, grammar) and fix an annoyance. * "x can't contain y because of z" sounds like it means "but x might contain y because of a reason OTHER than z" * wrong reference to Open Group specification * always interpret the specified "--output" as a directory BUG=none Committed: https://crrev.com/225bf680e62b2e6d51d2dc108c9098c96138093f Cr-Commit-Position: refs/heads/master@{#316139}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M base/files/file_path.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/dump_cache/cache_dumper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
dougk
5 years, 10 months ago (2015-02-12 21:06:24 UTC) #2
brettw
lgtm
5 years, 10 months ago (2015-02-12 22:51:43 UTC) #3
davidben
net lgtm
5 years, 10 months ago (2015-02-12 22:52:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922833002/1
5 years, 10 months ago (2015-02-13 00:43:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 02:48:03 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 02:48:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/225bf680e62b2e6d51d2dc108c9098c96138093f
Cr-Commit-Position: refs/heads/master@{#316139}

Powered by Google App Engine
This is Rietveld 408576698