Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 922823002: skydb shouldn't use origin on Linux (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

skydb shouldn't use origin on Linux Unfortunately, using --origin on Linux is slow and too painful to use at the moment. We should work on fixing that, but currently many of us have this in our local working copy anyway. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9e8f19321ada060571ded531c5a83a61bb286f2d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M sky/tools/skydb View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
abarth-chromium
5 years, 10 months ago (2015-02-12 20:27:32 UTC) #1
eseidel
lgtm
5 years, 10 months ago (2015-02-12 20:28:58 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 10 months ago (2015-02-12 20:30:35 UTC) #5
abarth-chromium
5 years, 10 months ago (2015-02-12 21:37:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9e8f19321ada060571ded531c5a83a61bb286f2d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698