Issue 922793002: Add an alternate contextual search url to extract the search terms from window.location.hash.

Issue 922793002: Add an alternate contextual search url to extract the search terms from window.location.hash. (Closed)

Created:
5 years, 10 months ago by kmadhusu

Modified:
5 years, 10 months ago

Reviewers:
Donn Denman, Peter Kasting, Use pkasting(at)chromium.org

CC:
chromium-reviews, vasilii+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add an alternate contextual search url to extract the search terms from window.location.hash. BUG=456353 Committed: https://crrev.com/5189942203e0623c59e9f33e977653d5061229d7 Cr-Commit-Position: refs/heads/master@{#316370}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
M	chrome/common/instant_types.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/instant_types_unittest.cc	View	1 2 3	1 chunk	+7 lines, -0 lines	0 comments	Download
M	components/search_engines/prepopulated_engines.json	View	1 2 3 4	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 16 (8 generated)

Donn Denman

Looks good to me except for the obvious (remove logging, add a bug number). Works ...

5 years, 10 months ago (2015-02-13 23:37:13 UTC) #2

kmadhusu

pkasting@: Please review prepopulated_engines.json changes. Thanks.

5 years, 10 months ago (2015-02-14 01:36:39 UTC) #7

Peter Kasting

Forgot. You need to bump the version number of the prepopulate data.

5 years, 10 months ago (2015-02-14 01:37:16 UTC) #10

kmadhusu

On 2015/02/14 01:37:16, Peter Kasting wrote: > Forgot. You need to bump the version number ...

5 years, 10 months ago (2015-02-14 01:39:15 UTC) #12

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922793002/120001

5 years, 10 months ago (2015-02-14 01:52:18 UTC) #14

commit-bot: I haz the power

5 years, 10 months ago (2015-02-14 03:11:03 UTC) #16

Message was sent while issue was closed.

Patchset 5 (id:??) landed as
https://crrev.com/5189942203e0623c59e9f33e977653d5061229d7
Cr-Commit-Position: refs/heads/master@{#316370}