Issue 922743002: Dispose Frame when detaching.

Issue 922743002: Dispose Frame when detaching. (Closed)

Created:
5 years, 10 months ago by lfg

Modified:
5 years, 9 months ago

Reviewers:
dcheng

CC:
blink-reviews, haraken, site-isolation-reviews_chromium.org, sofbjornf_opera.com

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Dispose Frame when detaching. This changes Frame::dispose() to be called on detach instead of on the destructor for non-oilpan builds. BUG=464764 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191454

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -10 lines)			Patch
	M	Source/core/frame/FrameView.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/core/frame/FrameView.cpp	View	1 2 3 4 5	4 chunks	+5 lines, -9 lines	0 comments	Download

Total messages: 8 (3 generated)

lfg

Hi Daniel, please take a look. This patch makes non-oilpan FrameView disposal to behave the ...

5 years, 9 months ago (2015-03-05 17:46:02 UTC) #2

dcheng

(I don't think there's a bug for detach/swap, so let's file a new one)

5 years, 9 months ago (2015-03-05 17:49:19 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922743002/100001

5 years, 9 months ago (2015-03-06 18:15:36 UTC) #7

commit-bot: I haz the power

5 years, 9 months ago (2015-03-06 19:03:30 UTC) #8

Message was sent while issue was closed.

Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191454