Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Side by Side Diff: content/renderer/scheduler/renderer_scheduler.h

Issue 922733002: scheduler: Implement task observers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_SCHEDULER_RENDERER_SCHEDULER_H_ 5 #ifndef CONTENT_RENDERER_SCHEDULER_RENDERER_SCHEDULER_H_
6 #define CONTENT_RENDERER_SCHEDULER_RENDERER_SCHEDULER_H_ 6 #define CONTENT_RENDERER_SCHEDULER_RENDERER_SCHEDULER_H_
7 7
8 #include "content/renderer/scheduler/single_thread_idle_task_runner.h" 8 #include "content/renderer/scheduler/single_thread_idle_task_runner.h"
9 #include "content/renderer/scheduler/task_queue_manager.h" 9 #include "content/renderer/scheduler/task_queue_manager.h"
10 #include "third_party/WebKit/public/web/WebInputEvent.h" 10 #include "third_party/WebKit/public/web/WebInputEvent.h"
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 // that this is a stricter condition than |IsHighPriorityWorkAnticipated|, 64 // that this is a stricter condition than |IsHighPriorityWorkAnticipated|,
65 // restricted to the case where real work is pending. 65 // restricted to the case where real work is pending.
66 // Must be called from the main thread. 66 // Must be called from the main thread.
67 virtual bool ShouldYieldForHighPriorityWork() = 0; 67 virtual bool ShouldYieldForHighPriorityWork() = 0;
68 68
69 // Shuts down the scheduler by dropping any remaining pending work in the work 69 // Shuts down the scheduler by dropping any remaining pending work in the work
70 // queues. After this call any work posted to the task runners will be 70 // queues. After this call any work posted to the task runners will be
71 // silently dropped. 71 // silently dropped.
72 virtual void Shutdown() = 0; 72 virtual void Shutdown() = 0;
73 73
74 // These functions can only be called on the main thread.
rmcilroy 2015/02/13 12:53:21 nit - could you add a comment to explain when the
Sami 2015/02/13 14:27:26 Sure thing, this comment was just copied verbatim
75 virtual void AddTaskObserver(
76 base::MessageLoop::TaskObserver* task_observer) = 0;
77 virtual void RemoveTaskObserver(
78 base::MessageLoop::TaskObserver* task_observer) = 0;
rmcilroy 2015/02/13 12:53:21 nit - move above Shutdown()
Sami 2015/02/13 14:27:26 Done.
79
74 protected: 80 protected:
75 RendererScheduler(); 81 RendererScheduler();
76 DISALLOW_COPY_AND_ASSIGN(RendererScheduler); 82 DISALLOW_COPY_AND_ASSIGN(RendererScheduler);
77 }; 83 };
78 84
79 } // namespace content 85 } // namespace content
80 86
81 #endif // CONTENT_RENDERER_SCHEDULER_RENDERER_SCHEDULER_H_ 87 #endif // CONTENT_RENDERER_SCHEDULER_RENDERER_SCHEDULER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698