scheduler: Implement task observers

content/renderer/scheduler/task_queue_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/scheduler/task_queue_manager.h"
 
 #include "base/test/test_simple_task_runner.h"
 #include "base/threading/thread.h"
 #include "cc/test/test_now_source.h"
 #include "content/renderer/scheduler/task_queue_selector.h"
@@ skipping 564 matching lines @@
   // the work batch is interrupted by the pending delayed task.
   EXPECT_EQ(test_task_runner_->GetPendingTasks().size(), 2u);
   test_task_runner_->RunPendingTasks();
   EXPECT_THAT(run_order, ElementsAre(2));
 
   // Running all remaining tasks should execute both pending tasks.
   test_task_runner_->RunUntilIdle();
   EXPECT_THAT(run_order, ElementsAre(2, 3, 1));
 }
 
+class TestTaskObserver : public base::MessageLoop::TaskObserver {
+ public:
+  TestTaskObserver() : will_count_(0), did_count_(0) {}
+
+  void DidProcessTask(const base::PendingTask& task) override { did_count_++; }
+
+  void WillProcessTask(const base::PendingTask& task) override {
+    will_count_++;
+  }
+
+  int CallsToWillProcess() const { return will_count_; }
+  int CallsToDidProcess() const { return did_count_; }
+
+ private:
+  int will_count_;
+  int did_count_;
+};
+
+TEST_F(TaskQueueManagerTest, TaskObserver) {
+  Initialize(1u);
+  TestTaskObserver observer;
+
+  EXPECT_EQ(0, observer.CallsToWillProcess());
+  EXPECT_EQ(0, observer.CallsToDidProcess());
+  manager_->AddTaskObserver(&observer);
+
+  std::vector<int> run_order;
+  scoped_refptr<base::SingleThreadTaskRunner> runner =
+      manager_->TaskRunnerForQueue(0);
+
+  runner->PostTask(FROM_HERE, base::Bind(&TestTask, 1, &run_order));
+  runner->PostTask(FROM_HERE, base::Bind(&TestTask, 2, &run_order));
+
+  selector_->AppendQueueToService(0);
+  selector_->AppendQueueToService(0);
+  test_task_runner_->RunUntilIdle();
+
+  EXPECT_EQ(2, observer.CallsToWillProcess());

[alex clarke (OOO till 29th), 2015/02/13 11:02:07]

Should this be split up into multiple tests so it's clearer what each test is
checking?

[Sami, 2015/02/13 12:09:09]

Good idea. I've split this into one test for adding and another test for
removing the observer.

+  EXPECT_EQ(2, observer.CallsToDidProcess());
+
+  manager_->RemoveTaskObserver(&observer);
+  runner->PostTask(FROM_HERE, base::Bind(&TestTask, 3, &run_order));
+  selector_->AppendQueueToService(0);
+  test_task_runner_->RunUntilIdle();
+
+  EXPECT_EQ(2, observer.CallsToWillProcess());
+  EXPECT_EQ(2, observer.CallsToDidProcess());
+}
+
 }  // namespace
 }  // namespace content