Issue 922713002: Remove legacy WebPageOverlay method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 922713002: Remove legacy WebPageOverlay method. (Closed)

Created:
5 years, 10 months ago by jbroman

Modified:
5 years, 10 months ago

Reviewers:
pdr., Mike West

CC:
blink-reviews, dglazkov+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Remove legacy WebPageOverlay method. All remaining overrides of the old method are removed by: https://codereview.chromium.org/920843002/ Thus the compatibility definitions of these methods can be removed, making this once again a pure virtual interface. BUG=450761 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190365

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -37 lines)			Patch
D	Source/web/WebPageOverlay.cpp	View	1 chunk	+0 lines, -30 lines	0 comments	Download
M	Source/web/web.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	public/web/WebPageOverlay.h	View	1 chunk	+1 line, -6 lines	0 comments	Download

Total messages: 6 (2 generated)

jbroman

Waiting on content/shell/ approval for https://codereview.chromium.org/920843002/; I intend to land this CL after that one, ...

5 years, 10 months ago (2015-02-13 18:56:18 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922713002/1

5 years, 10 months ago (2015-02-17 21:49:38 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-17 23:33:18 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190365