Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(901)

Issue 922673002: X87: silence C++ compiler warnings. (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: silence C++ compiler warnings. To solence C++ compiler warnings because is_mutable_ is only for CHECK. BUG= Committed: https://crrev.com/e1c2e8388816b701ef341f96ef7ec52a1bb2194d Cr-Commit-Position: refs/heads/master@{#26618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/x87/lithium-codegen-x87.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL. thanks
5 years, 10 months ago (2015-02-12 13:36:41 UTC) #2
Weiliang
lgtm
5 years, 10 months ago (2015-02-12 13:41:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922673002/1
5 years, 10 months ago (2015-02-12 13:42:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-12 14:40:04 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 14:40:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1c2e8388816b701ef341f96ef7ec52a1bb2194d
Cr-Commit-Position: refs/heads/master@{#26618}

Powered by Google App Engine
This is Rietveld 408576698