media/audio/fake_audio_consumer_unittest.cc - Issue 922663002: Moved the fake input stream's processing onto the audio worker thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/fake_audio_consumer_unittest.cc

Issue 922663002: Moved the fake input stream's processing onto the audio worker thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved flag logic from provider to input stream, added unit test Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc ('k') | media/audio/fake_audio_input_stream.h » ('j') | media/audio/fake_audio_provider_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/audio/fake_audio_consumer_unittest.cc

diff --git a/media/audio/fake_audio_consumer_unittest.cc b/media/audio/fake_audio_consumer_unittest.cc

index ab97eaea8c76c78fa263bd41793d26b58be50a00..6f8e45ce7806b34b8d9736ab328b08f03f7dea33 100644

--- a/media/audio/fake_audio_consumer_unittest.cc

+++ b/media/audio/fake_audio_consumer_unittest.cc

@@ -113,7 +113,7 @@ TEST_F(FakeAudioConsumerTest, TimeBetweenCallbacks) {

(end_time_ - start_time_) / (source_.callbacks() - 1);

// Ensure callback time is no faster than the expected time between callbacks.

- EXPECT_TRUE(actual_time_between_callbacks >= time_between_callbacks_);

+ EXPECT_GE(actual_time_between_callbacks, time_between_callbacks_);

// Softly check if the callback time is no slower than twice the expected time

// between callbacks. Since this test runs on the bots we can't be too strict