Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 922633002: [turbofan] Merge node-aux-data-inl.h into node-aux-data.h. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Merge node-aux-data-inl.h into node-aux-data.h. Google style guide forbids -inl.h headers. R=svenpanne@chromium.org Committed: https://crrev.com/3336d2e11e19750e6b9ca96415d14aad26967d8e Cr-Commit-Position: refs/heads/master@{#26611}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -57 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/node-aux-data.h View 2 chunks +17 lines, -8 lines 0 comments Download
D src/compiler/node-aux-data-inl.h View 1 chunk +0 lines, -43 lines 0 comments Download
M src/compiler/source-position.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Benedikt Meurer
5 years, 10 months ago (2015-02-12 12:09:22 UTC) #1
Benedikt Meurer
PTAL
5 years, 10 months ago (2015-02-12 12:09:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922633002/1
5 years, 10 months ago (2015-02-12 12:56:50 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-12 12:56:52 UTC) #6
Sven Panne
lgtm
5 years, 10 months ago (2015-02-12 12:59:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922633002/1
5 years, 10 months ago (2015-02-12 12:59:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-12 13:01:26 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 13:01:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3336d2e11e19750e6b9ca96415d14aad26967d8e
Cr-Commit-Position: refs/heads/master@{#26611}

Powered by Google App Engine
This is Rietveld 408576698