Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 922623002: [turbofan] Avoid ToNumber conversions if they could deoptimize. (Closed)

Created:
5 years, 10 months ago by Jarin
Modified:
5 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Avoid ToNumber conversions if they could deoptimize. BUG=chromium:454158 LOG=n R=bmeurer@chromium.org Committed: https://crrev.com/0b8063cec81191da91e136c35c461d8b12d1a6d9 Cr-Commit-Position: refs/heads/master@{#26661}

Patch Set 1 #

Patch Set 2 : Comment tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -8 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 2 chunks +14 lines, -8 lines 0 comments Download
A test/mjsunit/compiler/regress-to-number-binop-deopt.js View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jarin
Could you take a look, please?
5 years, 10 months ago (2015-02-12 12:11:20 UTC) #1
Benedikt Meurer
lgtm
5 years, 10 months ago (2015-02-12 18:50:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922623002/20001
5 years, 10 months ago (2015-02-16 12:57:56 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-16 12:59:16 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 12:59:33 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0b8063cec81191da91e136c35c461d8b12d1a6d9
Cr-Commit-Position: refs/heads/master@{#26661}

Powered by Google App Engine
This is Rietveld 408576698