Track code cache reject reason via histogram buckets.

Track code cache reject reason via histogram buckets.

R=vogelheim@chromium.org
BUG=chromium:441896
LOG=N

Committed: https://crrev.com/e7c235fa2dbc095d323c810dc2547f5e07a94117
Cr-Commit-Position: refs/heads/master@{#26660}

[vogelheim, 2015-02-16 12:01:36]

lgtm

https://codereview.chromium.org/922573003/diff/40001/src/serialize.cc
File src/serialize.cc (right):

https://codereview.chromium.org/922573003/diff/40001/src/serialize.cc#newcode...
src/serialize.cc:2679:
source->GetIsolate()->counters()->code_cache_reject_reason()->AddSample(r);
Just curious: Why count only the failures, and not all SanityCheckResult values?

(I guess it could go either way. One can easily reconstruct this by substituting
the deserialize count for CHECK_SUCCESS. The usual UIs don't make that easy,
however.)

[Yang, 2015-02-16 12:07:44]

On 2015/02/16 12:01:36, vogelheim wrote:
> lgtm
> 
> https://codereview.chromium.org/922573003/diff/40001/src/serialize.cc
> File src/serialize.cc (right):
> 
>
https://codereview.chromium.org/922573003/diff/40001/src/serialize.cc#newcode...
> src/serialize.cc:2679:
> source->GetIsolate()->counters()->code_cache_reject_reason()->AddSample(r);
> Just curious: Why count only the failures, and not all SanityCheckResult
values?
> 
> (I guess it could go either way. One can easily reconstruct this by
substituting
> the deserialize count for CHECK_SUCCESS. The usual UIs don't make that easy,
> however.)

Yeah I thought it was redundant data. I also named the histogram "reject
reason", so CHECK_SUCCESS wouldn't fit. I hope that's fine with you?

[Yang, 2015-02-16 12:36:34]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-02-16 12:37:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/922573003/40001

[commit-bot: I haz the power, 2015-02-16 12:39:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-16 12:39:25]

Patchset 3 (id:??) landed as
https://crrev.com/e7c235fa2dbc095d323c810dc2547f5e07a94117
Cr-Commit-Position: refs/heads/master@{#26660}