Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 922533005: Disable PhishingClassifierDelegateTest::NoScorer_Ref on ASan (Closed)

Created:
5 years, 10 months ago by rpaquay
Modified:
5 years, 10 months ago
Reviewers:
mattm
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable PhishingClassifierDelegateTest::NoScorer_Ref on ASan BUG=435719 TBR=mattm@chromium.org Committed: https://crrev.com/efcf8c72ce182e6182e8abc3904ed83931c41d68 Cr-Commit-Position: refs/heads/master@{#316245}

Patch Set 1 #

Patch Set 2 : Disable asan flaky test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922533005/20001
5 years, 10 months ago (2015-02-13 17:59:33 UTC) #2
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-13 18:37:14 UTC) #3
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/efcf8c72ce182e6182e8abc3904ed83931c41d68 Cr-Commit-Position: refs/heads/master@{#316245}
5 years, 10 months ago (2015-02-13 18:38:05 UTC) #4
mattm
On 2015/02/13 18:38:05, I haz the power (commit-bot) wrote: > Patchset 2 (id:??) landed as ...
5 years, 10 months ago (2015-02-13 20:53:01 UTC) #5
rpaquay
5 years, 10 months ago (2015-02-13 21:03:43 UTC) #6
Message was sent while issue was closed. 
On 2015/02/13 20:53:01, mattm wrote:
> On 2015/02/13 18:38:05, I haz the power (commit-bot) wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/efcf8c72ce182e6182e8abc3904ed83931c41d68
> > Cr-Commit-Position: refs/heads/master@{#316245}
> 
> In the future please include the test name in the CL description, thanks!
> 
> lgtm

Sorry about that. I went ahead and updated for future reference.

Powered by Google App Engine
This is Rietveld 408576698