Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: components/network_hints/renderer/renderer_preconnect.cc

Issue 922533003: Eliminated the logic that accumulated multiple preconnect requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use existing switches and fix runloop Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/network_hints/renderer/renderer_preconnect.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/network_hints/renderer/renderer_preconnect.cc
diff --git a/components/network_hints/renderer/renderer_preconnect.cc b/components/network_hints/renderer/renderer_preconnect.cc
index 4588b45a74a0faa0f3b70fca592a16e94e4ead2d..41d8033478e7c58ad2954ff81951f05e6ae9b9a3 100644
--- a/components/network_hints/renderer/renderer_preconnect.cc
+++ b/components/network_hints/renderer/renderer_preconnect.cc
@@ -6,10 +6,6 @@
#include "components/network_hints/renderer/renderer_preconnect.h"
-#include "base/bind.h"
-#include "base/location.h"
-#include "base/logging.h"
-#include "base/message_loop/message_loop.h"
#include "components/network_hints/common/network_hints_common.h"
#include "components/network_hints/common/network_hints_messages.h"
#include "content/public/renderer/render_thread.h"
@@ -18,43 +14,18 @@ using content::RenderThread;
namespace network_hints {
-RendererPreconnect::RendererPreconnect()
- : weak_factory_(this) {
+RendererPreconnect::RendererPreconnect() {
}
RendererPreconnect::~RendererPreconnect() {
}
-// Push URLs into the map quickly!
void RendererPreconnect::Preconnect(const GURL &url) {
if (!url.is_valid())
return;
- // If this is the first entry in the map then a task needs to be scheduled.
- bool needs_task = url_request_count_map_.empty();
-
- // ints will initialize to 0 automatically so incrementing will initialize
- // new URLs to 1 or increment existing URLs (exactly the desired behavior).
- url_request_count_map_[url]++;
-
- if (needs_task) {
- weak_factory_.InvalidateWeakPtrs();
- RenderThread::Get()->GetTaskRunner()->PostDelayedTask(
- FROM_HERE, base::Bind(&RendererPreconnect::SubmitPreconnect,
- weak_factory_.GetWeakPtr()),
- base::TimeDelta::FromMilliseconds(10));
- }
-}
-
-// Extract data from the Map, and then send it off the the Browser process
-// to be preconnected.
-void RendererPreconnect::SubmitPreconnect() {
- DCHECK(!url_request_count_map_.empty());
- for (const auto& entry : url_request_count_map_) {
- RenderThread::Get()->Send(
- new NetworkHintsMsg_Preconnect(entry.first, entry.second));
- }
- url_request_count_map_.clear();
+ RenderThread::Get()->Send(
+ new NetworkHintsMsg_Preconnect(url, 1));
}
} // namespace network_hints
« no previous file with comments | « components/network_hints/renderer/renderer_preconnect.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698