Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2923)

Unified Diff: chrome/browser/ui/extensions/extension_installed_bubble.h

Issue 922523005: [Extensions UI] Share more code in ExtensionInstalledBubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/extension_installed_bubble.h
diff --git a/chrome/browser/ui/extensions/extension_installed_bubble.h b/chrome/browser/ui/extensions/extension_installed_bubble.h
index 08bbf95f16c76b35d7f1be17ab941df200894192..dddf22837ece8d1d0f5841b7c73069355da75a03 100644
--- a/chrome/browser/ui/extensions/extension_installed_bubble.h
+++ b/chrome/browser/ui/extensions/extension_installed_bubble.h
@@ -15,6 +15,7 @@
class Browser;
namespace extensions {
+class Command;
class Extension;
class ExtensionRegistry;
}
@@ -64,10 +65,14 @@ class ExtensionInstalledBubble : public content::NotificationObserver,
const Browser* browser() const { return browser_; }
const SkBitmap& icon() const { return icon_; }
BubbleType type() const { return type_; }
+ bool has_command_keybinding() const { return action_command_; }
// Stop listening to NOTIFICATION_BROWSER_CLOSING.
void IgnoreBrowserClosing();
+ // Returns the string describing how to use the new extension.
+ base::string16 GetHowToUseDescription() const;
+
private:
// Delegates showing the view to our |view_|. Called internally via PostTask.
void ShowInternal();
@@ -95,6 +100,9 @@ class ExtensionInstalledBubble : public content::NotificationObserver,
BubbleType type_;
content::NotificationRegistrar registrar_;
+ // The command to execute the extension action, if one exists.
+ scoped_ptr<extensions::Command> action_command_;
+
// Listen to extension load, unloaded notifications.
ScopedObserver<extensions::ExtensionRegistry,
extensions::ExtensionRegistryObserver>

Powered by Google App Engine
This is Rietveld 408576698