[Extensions UI] Share more code in ExtensionInstalledBubble

chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h"
 
 #include "base/i18n/rtl.h"
-#include "base/mac/bundle_locations.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
-#include "chrome/browser/chrome_notification_types.h"
-#include "chrome/browser/extensions/api/commands/command_service.h"
 #include "chrome/browser/extensions/bundle_installer.h"
 #include "chrome/browser/extensions/extension_action.h"
 #include "chrome/browser/extensions/extension_action_manager.h"
-#include "chrome/browser/signin/signin_promo.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_navigator.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/chrome_pages.h"
 #include "chrome/browser/ui/chrome_style.h"
 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
 #include "chrome/browser/ui/cocoa/browser_window_controller.h"
 #include "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h"
 #include "chrome/browser/ui/cocoa/hover_close_button.h"
 #include "chrome/browser/ui/cocoa/info_bubble_view.h"
 #include "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
 #include "chrome/browser/ui/cocoa/new_tab_button.h"
 #include "chrome/browser/ui/cocoa/tabs/tab_strip_view.h"
 #include "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
 #include "chrome/browser/ui/extensions/extension_install_ui_factory.h"
 #include "chrome/browser/ui/extensions/extension_installed_bubble.h"
 #include "chrome/browser/ui/singleton_tabs.h"
 #include "chrome/browser/ui/sync/sync_promo_ui.h"
-#include "chrome/common/extensions/api/commands/commands_handler.h"
 #include "chrome/common/extensions/api/extension_action/action_info.h"
 #include "chrome/common/extensions/api/omnibox/omnibox_handler.h"
 #include "chrome/common/extensions/sync_helper.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
-#include "content/public/browser/notification_details.h"
-#include "content/public/browser/notification_registrar.h"
-#include "content/public/browser/notification_source.h"
+#include "components/signin/core/browser/signin_metrics.h"
 #include "extensions/browser/install/extension_install_ui.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/feature_switch.h"
 #import "skia/ext/skia_utils_mac.h"
 #import "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTweaker.h"
 #import "ui/base/cocoa/controls/hyperlink_text_view.h"
 #include "ui/base/l10n/l10n_util.h"
 
 using content::BrowserThread;
 using extensions::BundleInstaller;
 using extensions::Extension;
-using extensions::UnloadedExtensionInfo;
 
 class ExtensionInstalledBubbleBridge
     : public ExtensionInstalledBubble::Delegate {
  public:
   explicit ExtensionInstalledBubbleBridge(
       ExtensionInstalledBubbleController* controller);
   ~ExtensionInstalledBubbleBridge() override;
 
  private:
   // ExtensionInstalledBubble::Delegate:
@@ skipping 253 matching lines @@
   // Set appropriate icon, resizing if necessary.
   if ([icon_ size].width > extension_installed_bubble::kIconSize) {
     [icon_ setSize:NSMakeSize(extension_installed_bubble::kIconSize,
                               extension_installed_bubble::kIconSize)];
   }
   [iconImage_ setImage:icon_];
   [iconImage_ setNeedsDisplay:YES];
   return window;
 }
 
-- (bool)hasActivePageAction:(extensions::Command*)command {
-  extensions::CommandService* command_service =
-      extensions::CommandService::Get(browser_->profile());
-  if (type_ == extension_installed_bubble::kPageAction) {
-    if (extensions::CommandsInfo::GetPageActionCommand([self extension]) &&
-        command_service->GetPageActionCommand(
-            [self extension]->id(),
-            extensions::CommandService::ACTIVE,
-            command,
-            NULL)) {
-      return true;
-    }
-  }
-
-  return false;
-}
-
-- (bool)hasActiveBrowserAction:(extensions::Command*)command {
-  extensions::CommandService* command_service =
-      extensions::CommandService::Get(browser_->profile());
-  if (type_ == extension_installed_bubble::kBrowserAction) {
-    if (extensions::CommandsInfo::GetBrowserActionCommand([self extension]) &&
-        command_service->GetBrowserActionCommand(
-            [self extension]->id(),
-            extensions::CommandService::ACTIVE,
-            command,
-            NULL)) {
-      return true;
-    }
-  }
-
-  return false;
-}
-
-- (NSString*)installMessageForCurrentExtensionAction {
-  if (type_ == extension_installed_bubble::kPageAction) {
-    extensions::Command page_action_command;
-    if ([self hasActivePageAction:&page_action_command]) {
-      return l10n_util::GetNSStringF(
-          IDS_EXTENSION_INSTALLED_PAGE_ACTION_INFO_WITH_SHORTCUT,
-          page_action_command.accelerator().GetShortcutText());
-    } else {
-      return l10n_util::GetNSString(
-          IDS_EXTENSION_INSTALLED_PAGE_ACTION_INFO);
-    }
-  } else {
-    CHECK_EQ(extension_installed_bubble::kBrowserAction, type_);
-    extensions::Command browser_action_command;
-    if ([self hasActiveBrowserAction:&browser_action_command]) {
-      return l10n_util::GetNSStringF(
-          IDS_EXTENSION_INSTALLED_BROWSER_ACTION_INFO_WITH_SHORTCUT,
-          browser_action_command.accelerator().GetShortcutText());
-    } else {
-      return l10n_util::GetNSString(
-          IDS_EXTENSION_INSTALLED_BROWSER_ACTION_INFO);
-    }
-  }
-}
-
 // Calculate the height of each install message, resizing messages in their
 // frames to fit window width.  Return the new window height, based on the
 // total of all message heights.
 - (int)calculateWindowHeight {
   // Adjust the window height to reflect the sum height of all messages
   // and vertical padding.
   int newWindowHeight = 2 * extension_installed_bubble::kOuterVerticalMargin;
 
   // If type is bundle, list the extensions that were installed and those that
   // failed.
@@ skipping 52 matching lines @@
   [heading_ setStringValue:l10n_util::GetNSStringF(
       IDS_EXTENSION_INSTALLED_HEADING, extension_name)];
   [GTMUILocalizerAndLayoutTweaker
       sizeToFitFixedWidthTextField:heading_];
   newWindowHeight += NSHeight([heading_ frame]) +
       extension_installed_bubble::kInnerVerticalMargin;
 
   // If type is browser/page action, include a special message about them.
   if (type_ == extension_installed_bubble::kBrowserAction ||
       type_ == extension_installed_bubble::kPageAction) {
-    [howToUse_ setStringValue:[self
-        installMessageForCurrentExtensionAction]];
+    [howToUse_ setStringValue:base::SysUTF16ToNSString(
+         installedBubble_->GetHowToUseDescription())];
     [howToUse_ setHidden:NO];
     [[howToUse_ cell]
         setFont:[NSFont systemFontOfSize:[NSFont smallSystemFontSize]]];
     [GTMUILocalizerAndLayoutTweaker
         sizeToFitFixedWidthTextField:howToUse_];
     newWindowHeight += NSHeight([howToUse_ frame]) +
         extension_installed_bubble::kInnerVerticalMargin;
   }
 
   // If type is omnibox keyword, include a special message about the keyword.
   if (type_ == extension_installed_bubble::kOmniboxKeyword) {
-    [howToUse_ setStringValue:l10n_util::GetNSStringF(
-        IDS_EXTENSION_INSTALLED_OMNIBOX_KEYWORD_INFO,
-        base::UTF8ToUTF16(extensions::OmniboxInfo::GetKeyword(
-            [self extension])))];
+    [howToUse_ setStringValue:base::SysUTF16ToNSString(
+         installedBubble_->GetHowToUseDescription())];
     [howToUse_ setHidden:NO];
     [[howToUse_ cell]
         setFont:[NSFont systemFontOfSize:[NSFont smallSystemFontSize]]];
     [GTMUILocalizerAndLayoutTweaker
         sizeToFitFixedWidthTextField:howToUse_];
     newWindowHeight += NSHeight([howToUse_ frame]) +
         extension_installed_bubble::kInnerVerticalMargin;
   }
 
   // If type is app, hide howToManage_, and include a "show me" link in the
@@ skipping 14 matching lines @@
 
   // Sync sign-in promo, if any.
   if (sync_promo_height > 0) {
     NSRect promo_frame = [promo_.get() frame];
     promo_frame.size.height = sync_promo_height;
     [promo_.get() setFrame:promo_frame];
     newWindowHeight += extension_installed_bubble::kInnerVerticalMargin;
     newWindowHeight += sync_promo_height;
   }
 
-  extensions::Command command;
-  if ([self hasActivePageAction:&command] ||
-      [self hasActiveBrowserAction:&command]) {
+  if (installedBubble_->has_command_keybinding()) {
     [manageShortcutLink_ setHidden:NO];
     [[manageShortcutLink_ cell]
         setFont:[NSFont systemFontOfSize:[NSFont smallSystemFontSize]]];
     [[manageShortcutLink_ cell]
         setTextColor:gfx::SkColorToCalibratedNSColor(
             chrome_style::GetLinkColor())];
     [GTMUILocalizerAndLayoutTweaker sizeToFitView:manageShortcutLink_];
     newWindowHeight += extension_installed_bubble::kInnerVerticalMargin;
     newWindowHeight += NSHeight([manageShortcutLink_ frame]);
   }
@@ skipping 94 matching lines @@
   [howToManage_ setFrame:howToManageFrame];
 
   NSRect frame = howToManageFrame;
   if ([self showSyncPromo]) {
     frame = [promo_.get() frame];
     frame.origin.y = NSMinY(howToManageFrame) -
         (NSHeight(frame) + extension_installed_bubble::kInnerVerticalMargin);
     [promo_.get() setFrame:frame];
   }
 
-  extensions::Command command;
   if (![manageShortcutLink_ isHidden]) {
     NSRect manageShortcutFrame = [manageShortcutLink_ frame];
     manageShortcutFrame.origin.y = NSMinY(frame) - (
         NSHeight(manageShortcutFrame) +
         extension_installed_bubble::kInnerVerticalMargin);
     // Right-align the link.
     manageShortcutFrame.origin.x = NSMaxX(frame) -
                                    NSWidth(manageShortcutFrame);
     [manageShortcutLink_ setFrame:manageShortcutFrame];
   }
@@ skipping 35 matching lines @@
   install_ui->OpenAppInstalledUI([self extension]->id());
 }
 
 - (void)awakeFromNib {
   if (bundle_)
     return;
   [self initializeLabel];
 }
 
 @end