Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 922463005: Ash Tray Browser Test (Retry) (Closed)

Created:
5 years, 10 months ago by afakhry
Modified:
5 years, 10 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ash Tray Browser Test (Retry) This to make sure that after login, the system tray is always visible and within the bounds of the screen. R=nkostylev@chromium.org BUG=372838 TEST=interactive_ui_tests --gtest_filter=Login*Test.* Committed: https://crrev.com/b90079d8f837477dfd1ea8468a5823ee56125cb8 Cr-Commit-Position: refs/heads/master@{#318029}

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M chrome/browser/chromeos/login/login_browsertest.cc View 1 6 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (1 generated)
afakhry
5 years, 10 months ago (2015-02-12 18:55:32 UTC) #1
Nikita (slow)
https://codereview.chromium.org/922463005/diff/1/chrome/browser/chromeos/login/login_browsertest.cc File chrome/browser/chromeos/login/login_browsertest.cc (right): https://codereview.chromium.org/922463005/diff/1/chrome/browser/chromeos/login/login_browsertest.cc#newcode148 chrome/browser/chromeos/login/login_browsertest.cc:148: class LoginManagerTest : public InProcessBrowserTest { Please rename this ...
5 years, 10 months ago (2015-02-13 12:16:17 UTC) #2
afakhry
https://codereview.chromium.org/922463005/diff/1/chrome/browser/chromeos/login/login_browsertest.cc File chrome/browser/chromeos/login/login_browsertest.cc (right): https://codereview.chromium.org/922463005/diff/1/chrome/browser/chromeos/login/login_browsertest.cc#newcode151 chrome/browser/chromeos/login/login_browsertest.cc:151: command_line->AppendSwitch(chromeos::switches::kForceLoginManagerInTests); On 2015/02/13 12:16:17, Nikita wrote: > As discussed ...
5 years, 10 months ago (2015-02-13 16:59:49 UTC) #3
Nikita (slow)
On 2015/02/13 16:59:49, afakhry wrote: > https://codereview.chromium.org/922463005/diff/1/chrome/browser/chromeos/login/login_browsertest.cc > File chrome/browser/chromeos/login/login_browsertest.cc (right): > > https://codereview.chromium.org/922463005/diff/1/chrome/browser/chromeos/login/login_browsertest.cc#newcode151 > ...
5 years, 10 months ago (2015-02-13 17:55:54 UTC) #4
afakhry
On 2015/02/13 17:55:54, Nikita wrote: > On 2015/02/13 16:59:49, afakhry wrote: > > > https://codereview.chromium.org/922463005/diff/1/chrome/browser/chromeos/login/login_browsertest.cc ...
5 years, 10 months ago (2015-02-14 00:19:20 UTC) #5
Nikita (slow)
On 2015/02/14 00:19:20, afakhry wrote: > On 2015/02/13 17:55:54, Nikita wrote: > > On 2015/02/13 ...
5 years, 10 months ago (2015-02-16 08:12:03 UTC) #6
afakhry
On 2015/02/16 08:12:03, Nikita wrote: > On 2015/02/14 00:19:20, afakhry wrote: > > On 2015/02/13 ...
5 years, 10 months ago (2015-02-19 19:05:18 UTC) #7
afakhry
I think these tests are pretty much adequate to make sure that the regression mentioned ...
5 years, 10 months ago (2015-02-20 18:00:23 UTC) #8
Nikita (slow)
lgtm
5 years, 10 months ago (2015-02-25 11:51:55 UTC) #9
Nikita (slow)
lgtm
5 years, 10 months ago (2015-02-25 11:52:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922463005/20001
5 years, 10 months ago (2015-02-25 11:52:46 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-25 12:28:10 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 12:28:52 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b90079d8f837477dfd1ea8468a5823ee56125cb8
Cr-Commit-Position: refs/heads/master@{#318029}

Powered by Google App Engine
This is Rietveld 408576698